♻️ Enhancement/storage refactoring part 1

[sanderegg]

What do these changes do?

Split from and prequel to #3021, this changes are:

• use dict/list/tuple instead of Dict/List/Tuple in all of storage
• small refactoring
• renamed fileId query parameter to file_id for consistency
• removed extra_location/extra_source query parameters to get upload link (unused, @odeimaiz you might want to clean that out of the client code)

Related issue/s

How to test

Checklist

[codecov]

Codecov Report

Merging #3077 (e8d7861) into master (4ef961e) will increase coverage by 0.0%.
The diff coverage is 85.1%.

@@          Coverage Diff           @@
##           master   #3077   +/-   ##
======================================
  Coverage    80.9%   80.9%           
======================================
  Files         716     716           
  Lines       30896   30888    -8     
  Branches     4031    4030    -1     
======================================
- Hits        25017   25012    -5     
- Misses       5004    5006    +2     
+ Partials      875     870    -5     

Flag	Coverage Δ
integrationtests	66.2% <100.0%> (+<0.1%)	⬆️
unittests	76.8% <85.1%> (+<0.1%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...-library/src/models_library/api_schemas_storage.py	100.0% <ø> (ø)
...s/storage/src/simcore_service_storage/db_tokens.py	89.6% <ø> (-0.4%)	⬇️
...vice_webserver/exporter/formatters/formatter_v1.py	78.8% <ø> (ø)
.../src/simcore_service_webserver/storage_handlers.py	84.9% <ø> (ø)
...service_storage/datcore_adapter/datcore_adapter.py	32.0% <16.6%> (ø)
...es/storage/src/simcore_service_storage/handlers.py	73.6% <87.5%> (+1.0%)	⬆️
...torage/src/simcore_service_storage/access_layer.py	72.7% <100.0%> (ø)
services/storage/src/simcore_service_storage/db.py	71.4% <100.0%> (ø)
...ervices/storage/src/simcore_service_storage/dsm.py	72.2% <100.0%> (ø)
...ices/storage/src/simcore_service_storage/models.py	78.8% <100.0%> (ø)
... and 7 more

[GitHK]

👍

[GitHK]

so I guess this is no longer used?

[sanderegg]

was not used for years

[GitHK]

Question: I see no timeouts here. What if remote has an issue and hangs?

[sanderegg]

good point, but this is a pytest helper. anyway will remove it from this PR since it uses stuff that is not available in this PR...

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication