Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Is91/product customization (⚠️ devops) #3275

Merged
merged 26 commits into from
Aug 22, 2022

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Aug 19, 2022

What do these changes do?

  • ✨ Extends product customization options by extending the columns of the products pg table.
  • ♻️ Removes many of the env variables used for products customization and moved into the database. Specifically, these were the env vars removed from .env-devel and that must be moved into the products table
env var column
WEBSERVER_MANUAL_MAIN_URL, WEBSERVER_MANUAL_TI_URL manual_url
WEBSERVER_MANUAL_EXTRA_URL manual_extra_url
WEBSERVER_FOGBUGZ_LOGIN_URL issues_login_url
WEBSERVER_FOGBUGZ_NEWCASE_URL, WEBSERVER_S4L_FOGBUGZ_NEWCASE_URL, WEBSERVER_TIS_FOGBUGZ_NEWCASE_URL issues_new_url
WEBSERVER_FEEDBACK_FORM_URL feedback_form_url
  • EXTRA 📝: Implements e2e-portal-testing/issues#3: Improves user error messages for studies access (i.e. links used from the sparc portal)

⚠️ devops

  • remove env-vars in the table above and update database products tables

Related issue/s

How to test

cd services/web/server
pytest -vv --pdb tests/unit/*/test_statics*

Checklist

  • test migration
  • Openapi changes? make openapi-specs, git commit ... and then make version-*)
  • Database migration script? cd packages/postgres-database, make setup-commit, sc-pg review -m "my changes"
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@pcrespov pcrespov self-assigned this Aug 19, 2022
@pcrespov pcrespov added the a:webserver issue related to the webserver service label Aug 19, 2022
@pcrespov pcrespov force-pushed the is91/product-customization branch from 14b10c0 to 74390ae Compare August 19, 2022 13:26
@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #3275 (8443c68) into master (8443c68) will not change coverage.
The diff coverage is n/a.

❗ Current head 8443c68 differs from pull request most recent head 6165335. Consider uploading reports for the commit 6165335 to get more accurate results

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3275   +/-   ##
======================================
  Coverage    80.5%   80.5%           
======================================
  Files         725     725           
  Lines       30726   30726           
  Branches     3932    3932           
======================================
  Hits        24757   24757           
  Misses       5137    5137           
  Partials      832     832           
Flag Coverage Δ
integrationtests 66.6% <0.0%> (ø)
unittests 78.0% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@pcrespov pcrespov force-pushed the is91/product-customization branch 3 times, most recently from 1ce9a7e to 6c9cc5d Compare August 21, 2022 15:05
@pcrespov pcrespov changed the title WIP: ✨ Is91/product customization WIP: ✨ Is91/product customization (⚠️ devops) Aug 21, 2022
@pcrespov pcrespov added this to the Brutalism milestone Aug 21, 2022
@pcrespov pcrespov changed the title WIP: ✨ Is91/product customization (⚠️ devops) ✨ Is91/product customization (⚠️ devops) Aug 21, 2022
@pcrespov pcrespov marked this pull request as ready for review August 21, 2022 20:27
@pcrespov pcrespov force-pushed the is91/product-customization branch from 2aebe9a to 6165335 Compare August 22, 2022 06:42
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, thx. DevOps Changes are acknowledged :)

@pcrespov pcrespov merged commit d58564a into ITISFoundation:master Aug 22, 2022
@pcrespov pcrespov deleted the is91/product-customization branch August 22, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants