Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Is91/adds short name for Alphanumeric Sender ID (⚠️ devops) #3292

Merged
merged 5 commits into from
Aug 30, 2022

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Aug 29, 2022

What do these changes do?

  • ✨ new short_name column. Associated Product.short_name pydantic model guarantees it fits twilio specs for alphanumeric sender ID
  • ♻️ adds extra testing

⚠️ devops

  • update short_name in all products. To avoid problems during migration, it defaults to osparc but should be adapted in each case. Check with @odeimaiz

Related issue/s

How to test

cd services/web/server
make install-dev
pytest -vv tests/**/test_product*.py

Checklist

  • Database migration script? cd packages/postgres-database, make setup-commit, sc-pg review -m "my changes"
  • Unit tests for the changes exist
  • Runs in the swarm

@pcrespov pcrespov self-assigned this Aug 29, 2022
@pcrespov pcrespov changed the title ✨ Is91/adds short name for Alphanumeric Sender ID ✨ Is91/adds short name for Alphanumeric Sender ID (⚠️ devops) Aug 29, 2022
@pcrespov pcrespov added the a:webserver issue related to the webserver service label Aug 29, 2022
@pcrespov pcrespov added this to the Brutalism+1 milestone Aug 29, 2022
@pcrespov pcrespov marked this pull request as ready for review August 29, 2022 18:05
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #3292 (18af99f) into master (37d7e09) will increase coverage by 1.5%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3292      +/-   ##
=========================================
+ Coverage    80.5%   82.0%    +1.5%     
=========================================
  Files         453     749     +296     
  Lines       20659   31846   +11187     
  Branches     2429    4087    +1658     
=========================================
+ Hits        16639   26136    +9497     
- Misses       3485    4866    +1381     
- Partials      535     844     +309     
Flag Coverage Δ
integrationtests 66.2% <85.7%> (+0.1%) ⬆️
unittests 78.4% <100.0%> (+2.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/src/simcore_postgres_database/models/products.py 100.0% <ø> (ø)
...server/src/simcore_service_webserver/login/_2fa.py 86.0% <ø> (+30.2%) ⬆️
...er/src/simcore_service_webserver/login/handlers.py 83.2% <ø> (+43.0%) ⬆️
...s/models-library/src/models_library/basic_regex.py 100.0% <100.0%> (ø)
...erver/src/simcore_service_webserver/products_db.py 79.1% <100.0%> (+5.3%) ⬆️
...imcore_service_webserver/garbage_collector_core.py 69.8% <0.0%> (-1.9%) ⬇️
...ector_v2/modules/dynamic_sidecar/scheduler/task.py 81.1% <0.0%> (-1.3%) ⬇️
...ore_service_director_v2/utils/dask_client_utils.py 82.6% <0.0%> (-0.9%) ⬇️
...tor_v2/modules/dynamic_sidecar/scheduler/events.py 91.3% <0.0%> (ø)
...catalog/src/simcore_service_catalog/utils/pools.py 0.0% <0.0%> (ø)
... and 346 more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👌

@pcrespov pcrespov merged commit 6f7a4e1 into ITISFoundation:master Aug 30, 2022
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

devops changes acknowledged

@pcrespov pcrespov deleted the is91/fix-short-name branch August 30, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants