-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Is91/adds short name for Alphanumeric Sender ID (⚠️ devops) #3292
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3292 +/- ##
=========================================
+ Coverage 80.5% 82.0% +1.5%
=========================================
Files 453 749 +296
Lines 20659 31846 +11187
Branches 2429 4087 +1658
=========================================
+ Hits 16639 26136 +9497
- Misses 3485 4866 +1381
- Partials 535 844 +309
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
devops changes acknowledged
What do these changes do?
short_name
column. AssociatedProduct.short_name
pydantic model guarantees it fits twilio specs for alphanumeric sender IDshort_name
in all products. To avoid problems during migration, it defaults toosparc
but should be adapted in each case. Check with @odeimaizRelated issue/s
How to test
cd services/web/server make install-dev pytest -vv tests/**/test_product*.py
Checklist
cd packages/postgres-database
,make setup-commit
,sc-pg review -m "my changes"