Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Sometime docker timestamps are not parsed correctly #4003

Merged
merged 6 commits into from
Mar 27, 2023
Merged

🐛 Sometime docker timestamps are not parsed correctly #4003

merged 6 commits into from
Mar 27, 2023

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Mar 21, 2023 •
edited
Loading

What do these changes do?

adds arrow library to parse, convert and manage timestamps.
image
some referecences: https://stackabuse.com/working-with-datetime-in-python-with-arrow/

Very important: all times created with arrow are timezone aware and UTC by default

fixes the flaky test in autoscaling when reading a RFC3339Nano type of time stamp (as used by docker)

Related issue/s

fixes ITISFoundation/osparc-issues#675

How to test

Checklist

@sanderegg sanderegg added the a:services-library issues on packages/service-libs label Mar 21, 2023
@sanderegg sanderegg added this to the Mithril milestone Mar 21, 2023
@sanderegg sanderegg self-assigned this Mar 21, 2023
@codecov
Copy link

codecov bot commented Mar 21, 2023 •
edited
Loading

Codecov Report

Merging #4003 (7a86851) into master (df7200d) will decrease coverage by 12.4%.
The diff coverage is 50.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4003      +/-   ##
=========================================
- Coverage    84.6%   72.2%   -12.4%     
=========================================
  Files         946     552     -394     
  Lines       40979   24602   -16377     
  Branches      851     137     -714     
=========================================
- Hits        34678   17775   -16903     
- Misses       6079    6779     +700     
+ Partials      222      48     -174
Flag Coverage Δ
integrationtests 66.8% <50.0%> (+4.8%) ⬆️
unittests 64.7% <ø> (-17.5%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...r_v2/modules/dynamic_sidecar/docker_api/_volume.py 76.2% <50.0%> (-20.4%) ⬇️

... and 591 files with indirect coverage changes

@sanderegg sanderegg marked this pull request as ready for review March 21, 2023 10:18
mrnicegyu11
mrnicegyu11 approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, looks promissing!

@sanderegg sanderegg added a:storage issue related to storage service a:webserver issue related to the webserver service a:catalog catalog service a:director-v2 issue related with the director-v2 service a:apiserver api-server service a:dynamic-sidecar dynamic-sidecar service a:dask-service Any of the dask services: dask-scheduler/sidecar or worker a:autoscaling autoscaling service in simcore's stack a:agent agent service a:invitations invitations service labels Mar 21, 2023
matusdrobuliak66
matusdrobuliak66 approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice, I will use it in the UTC refactoring #3912

pcrespov
pcrespov approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@sanderegg sanderegg force-pushed the maintenance/fix_rfc3339_timezone_parsing branch 2 times, most recently from 6ae3498 to 86b0918 Compare March 23, 2023 07:54
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sanderegg sanderegg force-pushed the maintenance/fix_rfc3339_timezone_parsing branch 2 times, most recently from 0f468af to 9d9167d Compare March 23, 2023 10:54
@sanderegg sanderegg force-pushed the maintenance/fix_rfc3339_timezone_parsing branch from 9d9167d to 7a86851 Compare March 27, 2023 16:58
@codeclimate
Copy link

codeclimate bot commented Mar 27, 2023

Code Climate has analyzed commit 7a86851 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sanderegg sanderegg merged commit 935557a into ITISFoundation:master Mar 27, 2023
@sanderegg sanderegg deleted the maintenance/fix_rfc3339_timezone_parsing branch March 27, 2023 20:34
This was referenced Apr 3, 2023
Closed
Closed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 20, 2023
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitHK GitHK GitHK left review comments

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

@pcrespov pcrespov pcrespov approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@Surfict Surfict Awaiting requested review from Surfict

@colinRawlings colinRawlings Awaiting requested review from colinRawlings

Assignees

@sanderegg sanderegg

Labels
a:agent agent service a:apiserver api-server service a:autoscaling autoscaling service in simcore's stack a:catalog catalog service a:dask-service Any of the dask services: dask-scheduler/sidecar or worker a:director-v2 issue related with the director-v2 service a:dynamic-sidecar dynamic-sidecar service a:invitations invitations service a:services-library issues on packages/service-libs a:storage issue related to storage service a:webserver issue related to the webserver service
Projects
None yet
Milestone
Mithril
Development

Successfully merging this pull request may close these issues.

M1-12 Maintenance and DevOps
5 participants
@sanderegg @GitHK @mrnicegyu11 @pcrespov @matusdrobuliak66