-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 filetypes in webserver API are case insensitive #4041
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4041 +/- ##
=========================================
+ Coverage 78.5% 83.6% +5.1%
=========================================
Files 751 433 -318
Lines 33554 22251 -11303
Branches 496 137 -359
=========================================
- Hits 26354 18618 -7736
+ Misses 7072 3584 -3488
+ Partials 128 49 -79
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Code Climate has analyzed commit ad21421 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What do these changes do?
Searching for
filetype
values in the API is now case insensitive. To achieve that we enforce the values in the db (currently inserted by hand) to be uppercase and the search/comparison is done that way. Highlights:services_consume_filetypes.filetype
to ensure uppercasefiletype
as uppercaseRelated issue/s
Based on the feedback from @ignapas after testing interaction with nih-portal
How to test
services_consume_filetypes.filetype
wil raise a "CheckViolation" exception