Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Maintenance: missing updates in schemas #4066

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Apr 5, 2023

What do these changes do?

Minor updates on OAS and json-schemas

Related issue/s

How to test

@pcrespov pcrespov requested review from sanderegg and GitHK as code owners April 5, 2023 09:15
@pcrespov pcrespov self-assigned this Apr 5, 2023
@pcrespov pcrespov force-pushed the maintenance/minors_on_schemas branch from 694f249 to 8e0ab2a Compare April 5, 2023 09:16
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

api/specs/common/schemas/scripts/remove_definitions.py Outdated Show resolved Hide resolved
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove node-meta-v0.0.1.json from schemas in storage and webserver. It is created there automatically but it shouldn't be (is not needed) I have already a PR that fixes that. Thanks. (or I can remove it in the fix)

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #4066 (2a42b59) into master (1e7a0af) will decrease coverage by 6.4%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4066      +/-   ##
=========================================
- Coverage    85.4%   79.1%    -6.4%     
=========================================
  Files         951     434     -517     
  Lines       41262   22344   -18918     
  Branches      957     174     -783     
=========================================
- Hits        35276   17686   -17590     
+ Misses       5767    4609    -1158     
+ Partials      219      49     -170     
Flag Coverage Δ
integrationtests 61.7% <ø> (-4.9%) ⬇️
unittests 84.8% <ø> (+2.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 620 files with indirect coverage changes

@pcrespov pcrespov force-pushed the maintenance/minors_on_schemas branch from 8e0ab2a to 4a0bc32 Compare April 6, 2023 08:10
@codeclimate
Copy link

codeclimate bot commented Apr 6, 2023

Code Climate has analyzed commit 2a42b59 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov enabled auto-merge (squash) April 6, 2023 09:49
@pcrespov pcrespov merged commit 352cca1 into ITISFoundation:master Apr 6, 2023
@pcrespov pcrespov deleted the maintenance/minors_on_schemas branch April 25, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants