Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ webserver: fixes mypy issues in meta_modeling plugin #4113

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Apr 14, 2023

What do these changes do?

  • fixes mypy issues in webserver's meta_modeling plugin
  • moves plugin to folder meta_modeling
    • shortens names of plugin modules
    • protected-prefix (_) for internal modules (i.e. cannot be imported outside the plugin)
  • reviews notes in code and creates Maintenance: webserver meta_modeling fixes and todos #4124

Related issue/s

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #4113 (2a1ebda) into master (fe45616) will decrease coverage by 8.7%.
The diff coverage is 96.2%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4113      +/-   ##
=========================================
- Coverage    86.7%   78.1%    -8.7%     
=========================================
  Files         799     398     -401     
  Lines       37352   20631   -16721     
  Branches      879     174     -705     
=========================================
- Hits        32391   16115   -16276     
+ Misses       4758    4467     -291     
+ Partials      203      49     -154     
Flag Coverage Δ
integrationtests 61.6% <85.1%> (-5.0%) ⬇️
unittests 84.0% <96.2%> (+0.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ervice_webserver/meta_modeling/_version_control.py 83.0% <80.0%> (ø)
...erver/src/simcore_service_webserver/application.py 97.8% <100.0%> (ø)
...service_webserver/meta_modeling/_function_nodes.py 66.6% <100.0%> (ø)
...ore_service_webserver/meta_modeling/_iterations.py 87.9% <100.0%> (ø)
...mcore_service_webserver/meta_modeling/_projects.py 64.1% <100.0%> (ø)
..._service_webserver/meta_modeling/_rest_handlers.py 84.2% <100.0%> (ø)
...imcore_service_webserver/meta_modeling/_results.py 91.1% <100.0%> (ø)
.../simcore_service_webserver/meta_modeling/plugin.py 100.0% <100.0%> (ø)

... and 509 files with indirect coverage changes

@pcrespov pcrespov force-pushed the is4071/mypy-webserver-metamodeling branch from 1e3bdf0 to 2ddb5fb Compare April 14, 2023 14:32
@pcrespov pcrespov self-assigned this Apr 14, 2023
@pcrespov pcrespov changed the title WIP:♻️ webserver: Is4071/mypy webserver metamodeling ♻️ webserver: fixes mypy issues in meta_modeling plugin Apr 14, 2023
@pcrespov pcrespov added a:webserver issue related to the webserver service t:maintenance Some planned maintenance work labels Apr 14, 2023
@pcrespov pcrespov added this to the Jelly Beans milestone Apr 14, 2023
@pcrespov pcrespov marked this pull request as ready for review April 14, 2023 14:35
@pcrespov pcrespov force-pushed the is4071/mypy-webserver-metamodeling branch from 2ddb5fb to a57a61c Compare April 16, 2023 18:52
@pcrespov pcrespov enabled auto-merge (squash) April 16, 2023 18:53
@codeclimate
Copy link

codeclimate bot commented Apr 16, 2023

Code Climate has analyzed commit 2a1ebda and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov merged commit 87322e1 into ITISFoundation:master Apr 16, 2023
@pcrespov pcrespov deleted the is4071/mypy-webserver-metamodeling branch April 17, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants