-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Rabbitmq/only listens to logs if needed #4180
🎨 Rabbitmq/only listens to logs if needed #4180
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4180 +/- ##
=========================================
+ Coverage 65.8% 84.3% +18.4%
=========================================
Files 370 961 +591
Lines 19140 41640 +22500
Branches 0 955 +955
=========================================
+ Hits 12605 35111 +22506
+ Misses 6535 6325 -210
- Partials 0 204 +204
Flags with carried forward coverage won't be shown. Click here to find out more.
|
843b236
to
329d6a0
Compare
a9bdd6f
to
8507cbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
7ab6cbc
to
8c81f8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement! thx!
Regarding IMPORTANT NOTE: currently this will work because we use sticky connections!!
Is there a way to add a test that reminds us about this condition in case sometime is broken? For instance, just a test that checks "stickiness" and raises an error with this note!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
4eb76cd
to
4345052
Compare
Code Climate has analyzed commit 4345052 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
Bonuses:
IMPORTANT NOTE: currently this will work because we use sticky connections!!
NOTE2: The studies running through the oSparc API will not generate load on the webserver(s) anymore.
NOTE3: The studies running through one specific instance of the webserver will not load the other for nothing anymore.
NOTE4: Expected reduction of CPU load on the webservers.
Related issue/s
How to test
DevOps Checklist