♻️ Propagate can_save when starting service 🚨

[GitHK]

What do these changes do?

NOTE: This was already part of #4044 which had to be reverted

The can_save can also be computed once the service is started. For new style (the ones running via dynamic sidecar), it is useful when the services are closed to address some edge cases where the content was saved without having permission to do so.

🚨 Updated legacy data format. Should not have any impact, keep an eye on it on master and staging, if no errors occur in director-v2 should be OK!

Related issue/s

• followup after reverting ♻️ Volumes keep track if the data requires saving 🚨 #3974
• potentially required by Read only study uploads outputs for dynamic services #4044
• closes ♻️ remove code once it hits production #3990 #3996

How to test

DevOps Checklist

[codecov]

Codecov Report

Merging #4202 (72d4c30) into master (f6c6d69) will increase coverage by 8.5%.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##           master   #4202     +/-   ##
========================================
+ Coverage    76.8%   85.3%   +8.5%     
========================================
  Files         881     788     -93     
  Lines       39011   36867   -2144     
  Branches      877     452    -425     
========================================
+ Hits        29987   31480   +1493     
+ Misses       8823    5278   -3545     
+ Partials      201     109     -92     

Flag	Coverage Δ
integrationtests	52.4% <66.6%> (-0.1%)	⬇️
unittests	83.0% <100.0%> (+7.6%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...service_director_v2/api/routes/dynamic_services.py	89.6% <ø> (+6.6%)	⬆️
...ector_v2/modules/dynamic_sidecar/scheduler/_abc.py	100.0% <ø> (ø)
...ules/dynamic_sidecar/scheduler/_core/_scheduler.py	78.6% <ø> (+10.9%)	⬆️
...ctor_v2/modules/dynamic_sidecar/scheduler/_task.py	94.2% <ø> (+11.5%)	⬆️
...ce_webserver/director_v2/_core_dynamic_services.py	72.7% <ø> (+13.6%)	⬆️
...ckages/models-library/src/models_library/docker.py	86.2% <100.0%> (-3.8%)	⬇️
...ages/models-library/src/models_library/products.py	100.0% <100.0%> (ø)
...ice_director_v2/models/domains/dynamic_services.py	100.0% <100.0%> (ø)
...or_v2/models/schemas/dynamic_services/scheduler.py	98.7% <100.0%> (+5.5%)	⬆️
...simcore_service_webserver/projects/projects_api.py	93.5% <100.0%> (+20.1%)	⬆️

... and 320 files with indirect coverage changes

[codeclimate]

Code Climate has analyzed commit 72d4c30 and detected 0 issues on this pull request.

View more on Code Climate.

[sonarqubecloud]

Please retry analysis of this Pull-Request directly on SonarCloud.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.1% Duplication