Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️Maintenance: remove unmaintained fastapi-contrib package #4206

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented May 9, 2023

What do these changes do?

  • removes fastapi-contrib package that did not receive any update since 2021.
  • fixes some pytest warnings due to the package
  • might help unflake the director-v2 int test for mixed new and legacy services

Tracing will be added again within #4028 using different more uptodate packages

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg added a:services-library issues on packages/service-libs a:catalog catalog service a:director-v2 issue related with the director-v2 service a:apiserver api-server service a:dynamic-sidecar dynamic-sidecar service a:autoscaling autoscaling service in simcore's stack a:invitations invitations service labels May 9, 2023
@sanderegg sanderegg added this to the Pastel de Nata milestone May 9, 2023
@sanderegg sanderegg requested a review from matusdrobuliak66 May 9, 2023 07:54
@sanderegg sanderegg self-assigned this May 9, 2023
@sanderegg sanderegg requested review from pcrespov and GitHK as code owners May 9, 2023 07:54
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #4206 (ca5c641) into master (10c4f3f) will decrease coverage by 0.6%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4206     +/-   ##
========================================
- Coverage    85.4%   84.8%   -0.6%     
========================================
  Files         951     804    -147     
  Lines       40927   35849   -5078     
  Branches      953     543    -410     
========================================
- Hits        34963   30435   -4528     
+ Misses       5747    5285    -462     
+ Partials      217     129     -88     
Flag Coverage Δ
integrationtests 60.6% <ø> (-6.7%) ⬇️
unittests 82.4% <100.0%> (+0.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/simcore_service_api_server/core/application.py 98.1% <ø> (+1.6%) ⬆️
...er/src/simcore_service_api_server/core/settings.py 98.5% <ø> (-0.1%) ⬇️
...catalog/src/simcore_service_catalog/core/events.py 100.0% <ø> (+2.9%) ⬆️
...imcore_service_datcore_adapter/core/application.py 100.0% <ø> (+2.3%) ⬆️
...c/simcore_service_datcore_adapter/core/settings.py 100.0% <ø> (ø)
...rc/simcore_service_director_v2/core/application.py 97.2% <ø> (-0.2%) ⬇️
...2/src/simcore_service_director_v2/core/settings.py 98.4% <ø> (-0.1%) ⬇️
...talog/src/simcore_service_catalog/core/settings.py 100.0% <100.0%> (ø)

... and 199 files with indirect coverage changes

@sanderegg sanderegg force-pushed the maintenance/remove_unmaintained_package branch from baa2511 to 6915f0d Compare May 9, 2023 08:40
@sanderegg sanderegg enabled auto-merge (squash) May 9, 2023 08:41
@sanderegg sanderegg force-pushed the maintenance/remove_unmaintained_package branch from 6915f0d to ca5c641 Compare May 9, 2023 10:14
@codeclimate
Copy link

codeclimate bot commented May 9, 2023

Code Climate has analyzed commit ca5c641 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sanderegg sanderegg merged commit 8ebb2e3 into ITISFoundation:master May 9, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
24 tasks
@sanderegg sanderegg deleted the maintenance/remove_unmaintained_package branch June 8, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:apiserver api-server service a:autoscaling autoscaling service in simcore's stack a:catalog catalog service a:director-v2 issue related with the director-v2 service a:dynamic-sidecar dynamic-sidecar service a:invitations invitations service a:services-library issues on packages/service-libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants