♻️ fixing mypy issues in director-v2 part3

[GitHK]

What do these changes do?

• ♻️ moving scheduler internals around to make mypy and codeclimate happy!
• 🐛 more typing fixes

Related issue/s

• Maintenance: make mypy pass in all services/packages in repo #4071
• M1-12 Maintenance and DevOps osparc-issues#675
• closes director-v2 mypy Part 3 followup #4150

How to test

DevOps Checklist

[codecov]

Codecov Report

Merging #4211 (815ef7c) into master (3ef87fb) will decrease coverage by 16.2%.
The diff coverage is 82.6%.

@@            Coverage Diff            @@
##           master   #4211      +/-   ##
=========================================
- Coverage    85.5%   69.4%   -16.2%     
=========================================
  Files         953     394     -559     
  Lines       41354   20510   -20844     
  Branches      953     173     -780     
=========================================
- Hits        35382   14236   -21146     
- Misses       5755    6225     +470     
+ Partials      217      49     -168     

Flag	Coverage Δ
integrationtests	61.8% <69.2%> (-6.7%)	⬇️
unittests	85.5% <82.6%> (+3.2%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...2/src/simcore_service_director_v2/core/settings.py	98.4% <ø> (ø)
...or_v2/models/schemas/dynamic_services/scheduler.py	96.2% <ø> (-2.5%)	⬇️
...ector_v2/modules/dynamic_sidecar/scheduler/_abc.py	100.0% <ø> (ø)
...e_service_director_v2/modules/projects_networks.py	74.4% <0.0%> (-0.9%)	⬇️
...ynamic_sidecar/scheduler/_core/_scheduler_utils.py	77.5% <67.5%> (-22.5%)	⬇️
...ules/dynamic_sidecar/scheduler/_core/_scheduler.py	80.9% <94.8%> (+2.3%)	⬆️
...-v2/src/simcore_service_director_v2/cli/_client.py	100.0% <100.0%> (ø)
...ore_service_director_v2/models/schemas/clusters.py	98.8% <100.0%> (-0.1%)	⬇️
...ctor_v2/models/schemas/dynamic_services/service.py	100.0% <100.0%> (ø)

... and 745 files with indirect coverage changes

[pcrespov]

Please consider my comments. thx

[sanderegg]

Please modify the changes in cluster.py so I can drop them in my PR. thanks

[sanderegg]

Please modify the changes in cluster.py so I can drop them in my PR. thanks

[sanderegg]

thanks!

[sanderegg]

thanks!

[codeclimate]

Code Climate has analyzed commit 815ef7c and detected 0 issues on this pull request.

View more on Code Climate.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.1% Duplication