Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ TIP v2: 2 plus buttons #4218

Merged
merged 4 commits into from
May 10, 2023
Merged

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented May 10, 2023

What do these changes do?

This PR adds a second plus button for the TI product. In order to show them, the corresponding templates need to be available: the first plus button will point to a template labeled "TI Planning Tool", while for the second one "mTI Planning Tool" is required.

TwoPlusButtons

Bonus:

  • First_name, Last_name and email in tooltip on "Share with" list
  • Fix SAR e2e test: throw errors

Related issue/s

related to ITISFoundation/osparc-issues#831

How to test

DevOps Checklist

@odeimaiz odeimaiz self-assigned this May 10, 2023
@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:✨new-feature labels May 10, 2023
@odeimaiz odeimaiz marked this pull request as ready for review May 10, 2023 15:26
@odeimaiz odeimaiz enabled auto-merge (squash) May 10, 2023 16:09
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codeclimate
Copy link

codeclimate bot commented May 10, 2023

Code Climate has analyzed commit 8b3ff1e and detected 0 issues on this pull request.

View more on Code Climate.

@pcrespov pcrespov added this to the Pastel de Nata milestone May 10, 2023
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz merged commit 0f9de05 into ITISFoundation:master May 10, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
24 tasks
@odeimaiz odeimaiz deleted the feature/tip-ii branch August 20, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants