Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Computational backend: correct parsing of log lines #4220

Merged
merged 1 commit into from
May 11, 2023

Conversation

sanderegg
Copy link
Member

What do these changes do?

  • fixed some issues with parsing progress logs output by old computational services
  • improved reliability

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg requested a review from pcrespov as a code owner May 11, 2023 05:55
@sanderegg sanderegg self-assigned this May 11, 2023
@sanderegg sanderegg added the a:dask-service Any of the dask services: dask-scheduler/sidecar or worker label May 11, 2023
@sanderegg sanderegg added this to the Pastel de Nata milestone May 11, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented May 11, 2023

Code Climate has analyzed commit 786c2ea and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #4220 (786c2ea) into master (0f9de05) will decrease coverage by 1.0%.
The diff coverage is 95.2%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4220     +/-   ##
========================================
- Coverage    84.6%   83.7%   -1.0%     
========================================
  Files         953     796    -157     
  Lines       41350   35597   -5753     
  Branches      953     543    -410     
========================================
- Hits        34996   29803   -5193     
+ Misses       6137    5665    -472     
+ Partials      217     129     -88     
Flag Coverage Δ
integrationtests 68.4% <ø> (-0.2%) ⬇️
unittests 81.6% <95.2%> (+0.3%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ges/service-library/src/servicelib/docker_utils.py 100.0% <ø> (ø)
...dask_sidecar/computational_sidecar/docker_utils.py 93.1% <95.2%> (-0.5%) ⬇️

... and 243 files with indirect coverage changes

@sanderegg sanderegg merged commit b7f2bcc into ITISFoundation:master May 11, 2023
@sanderegg sanderegg deleted the dask/fix-parsing-logs branch May 11, 2023 06:44
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dask-service Any of the dask services: dask-scheduler/sidecar or worker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants