Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛service logs file not uploaded when service failing #4242

Merged
merged 11 commits into from
May 16, 2023

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented May 16, 2023

What do these changes do?

  • fixes issue where logs might not get uploaded when the computational service would fail
  • fixes double logs in the service console
  • log level guessing improved to also find out about exceptions in code
  • a bit of refactoring does not hurt
  • re-enabled PublicAPI test

Related issue/s

How to test

DevOps Checklist

Sorry, something went wrong.

@sanderegg sanderegg added this to the Pastel de Nata milestone May 16, 2023
@sanderegg sanderegg self-assigned this May 16, 2023
@sanderegg sanderegg marked this pull request as ready for review May 16, 2023 08:25
@sanderegg sanderegg requested a review from pcrespov as a code owner May 16, 2023 08:25
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #4242 (ebb6f6d) into master (dab760d) will decrease coverage by 0.8%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4242     +/-   ##
========================================
- Coverage    84.5%   83.7%   -0.8%     
========================================
  Files         956     799    -157     
  Lines       41482   35704   -5778     
  Branches      957     547    -410     
========================================
- Hits        35054   29897   -5157     
+ Misses       6210    5677    -533     
+ Partials      218     130     -88     
Flag Coverage Δ
integrationtests 68.5% <ø> (+15.0%) ⬆️
unittests 81.6% <100.0%> (-0.7%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/service-library/src/servicelib/logging_utils.py 71.4% <ø> (ø)
...service_dask_sidecar/computational_sidecar/core.py 100.0% <100.0%> (ø)
...dask_sidecar/computational_sidecar/docker_utils.py 91.1% <100.0%> (-2.0%) ⬇️
...idecar/computational_sidecar/task_shared_volume.py 92.1% <100.0%> (-0.3%) ⬇️
...car/src/simcore_service_dask_sidecar/dask_utils.py 96.2% <100.0%> (-0.1%) ⬇️
...car/src/simcore_service_dask_sidecar/file_utils.py 98.1% <100.0%> (-0.1%) ⬇️
...-sidecar/src/simcore_service_dask_sidecar/tasks.py 84.0% <100.0%> (+0.4%) ⬆️

... and 248 files with indirect coverage changes

tests/public-api/test_solvers_jobs_api.py Outdated Show resolved Hide resolved
@sanderegg sanderegg enabled auto-merge (squash) May 16, 2023 08:59
@sanderegg sanderegg requested a review from mguidon May 16, 2023 09:00
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sanderegg sanderegg force-pushed the bugfix/logs-not-uploaded branch 2 times, most recently from e36b3ef to 2ccf642 Compare May 16, 2023 11:55
@sanderegg sanderegg force-pushed the bugfix/logs-not-uploaded branch from 2ccf642 to ebb6f6d Compare May 16, 2023 12:57
@codeclimate
Copy link

codeclimate bot commented May 16, 2023

Code Climate has analyzed commit ebb6f6d and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants