-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Backend support for min-visible-inputs label #4243
✨ Backend support for min-visible-inputs label #4243
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4243 +/- ##
========================================
- Coverage 85.5% 84.5% -1.1%
========================================
Files 956 796 -160
Lines 41512 37055 -4457
Branches 961 455 -506
========================================
- Hits 35522 31318 -4204
+ Misses 5771 5628 -143
+ Partials 219 109 -110
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…-visible-inputs-label
…-visible-inputs-label
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks. Just a minor comment.
I was surprised to see that this doesn't require any change in the dynamic sidecar.
…-visible-inputs-label
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
followed up the discussion online. If possible, add a test that check labels convention for future additions ...
…-visible-inputs-label
…-visible-inputs-label
Code Climate has analyzed commit 344ba7e and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
Backend will now correctly parse services exposing the label
io.simcore.min-visible-inputs: '{"min-visible-inputs": 2}'
.NOTE:
itisfoundation/ci-service-integration-library:v1.0.1-dev-43
Related issue/s
How to test
DevOps Checklist