Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Backend support for min-visible-inputs label #4243

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented May 16, 2023

What do these changes do?

Backend will now correctly parse services exposing the label io.simcore.min-visible-inputs: '{"min-visible-inputs": 2}'.

NOTE:

  • to release service with this new label use itisfoundation/ci-service-integration-library:v1.0.1-dev-43
  • jupyter-math was also updated to support these options

Screenshot 2023-05-17 at 12 39 37

Related issue/s

How to test

DevOps Checklist

@GitHK GitHK self-assigned this May 16, 2023
@GitHK GitHK added this to the Pastel de Nata milestone May 16, 2023
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #4243 (344ba7e) into master (4c67ade) will decrease coverage by 1.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4243     +/-   ##
========================================
- Coverage    85.5%   84.5%   -1.1%     
========================================
  Files         956     796    -160     
  Lines       41512   37055   -4457     
  Branches      961     455    -506     
========================================
- Hits        35522   31318   -4204     
+ Misses       5771    5628    -143     
+ Partials      219     109    -110     
Flag Coverage Δ
integrationtests 68.7% <ø> (+<0.1%) ⬆️
unittests 82.6% <100.0%> (+0.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/models-library/src/models_library/services.py 93.7% <100.0%> (+<0.1%) ⬆️
...tegration/src/service_integration/osparc_config.py 87.8% <100.0%> (+<0.1%) ⬆️

... and 221 files with indirect coverage changes

@GitHK GitHK marked this pull request as ready for review May 17, 2023 11:35
@GitHK GitHK requested a review from elisabettai May 17, 2023 11:35
@GitHK GitHK changed the title ✨ Backend support for minVisibleInputs ✨ Backend support for min-visible-inputs label May 17, 2023
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks. Just a minor comment.

I was surprised to see that this doesn't require any change in the dynamic sidecar.

packages/models-library/src/models_library/services.py Outdated Show resolved Hide resolved
@GitHK GitHK requested a review from elisabettai May 17, 2023 11:57
@GitHK GitHK requested a review from pcrespov May 17, 2023 12:57
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

followed up the discussion online. If possible, add a test that check labels convention for future additions ...

@GitHK GitHK enabled auto-merge (squash) May 18, 2023 08:20
@codeclimate
Copy link

codeclimate bot commented May 18, 2023

Code Climate has analyzed commit 344ba7e and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@GitHK GitHK merged commit 7c42749 into ITISFoundation:master May 18, 2023
@GitHK GitHK deleted the pr-osparc-add-min-visible-inputs-label branch May 18, 2023 09:47
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants