Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ fixes mypy in integration-library package #4307

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jun 2, 2023

What do these changes do?

  • ♻️ fixes mypy issues in integration-library package
  • adds CI typecheck step

Related issue/s

How to test

cd packages/integration-library
make install-dev
make mypy 

@pcrespov pcrespov self-assigned this Jun 2, 2023
@pcrespov pcrespov added the a:ooil integration-library or ooil label Jun 2, 2023
@pcrespov pcrespov added this to the Pastel de Nata milestone Jun 2, 2023
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Jun 2, 2023
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #4307 (679fe1e) into master (74ce825) will increase coverage by 17.7%.
The diff coverage is 93.1%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4307      +/-   ##
=========================================
+ Coverage    67.8%   85.6%   +17.7%     
=========================================
  Files         393     802     +409     
  Lines       20439   35228   +14789     
  Branches      173     378     +205     
=========================================
+ Hits        13873   30161   +16288     
+ Misses       6517    4980    -1537     
- Partials       49      87      +38     
Flag Coverage Δ
integrationtests 68.0% <ø> (+0.1%) ⬆️
unittests 82.6% <93.1%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ce_integration/pytest_plugin/docker_integration.py 0.0% <0.0%> (ø)
...rvice_integration/pytest_plugin/validation_data.py 0.0% <0.0%> (ø)
...n/src/service_integration/service/pytest_runner.py 50.0% <0.0%> (ø)
...gration/src/service_integration/commands/config.py 80.0% <52.9%> (ø)
...e_integration/_compose_spec_model_autogenerated.py 100.0% <100.0%> (ø)
...service-integration/src/service_integration/cli.py 84.0% <100.0%> (ø)
...ration/src/service_integration/commands/compose.py 75.8% <100.0%> (ø)
...tion/src/service_integration/compose_spec_model.py 100.0% <100.0%> (ø)
...tion/src/service_integration/labels_annotations.py 90.6% <100.0%> (ø)
...egration/src/service_integration/oci_image_spec.py 93.1% <100.0%> (ø)
... and 2 more

... and 622 files with indirect coverage changes

@pcrespov pcrespov force-pushed the is4071/mypy-integration-library branch from c32bfce to 850e4f2 Compare June 6, 2023 15:04
@pcrespov pcrespov changed the title WIP: ♻️ fixes mypy in integration-library package ♻️ fixes mypy in integration-library package Jun 6, 2023
@pcrespov pcrespov force-pushed the is4071/mypy-integration-library branch from 850e4f2 to f9b813a Compare June 6, 2023 15:05
@pcrespov pcrespov marked this pull request as ready for review June 6, 2023 15:05
@pcrespov pcrespov requested review from sanderegg and GitHK as code owners June 6, 2023 15:05
@pcrespov pcrespov requested a review from matusdrobuliak66 June 6, 2023 15:06
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Jun 6, 2023

Code Climate has analyzed commit 679fe1e and detected 0 issues on this pull request.

View more on Code Climate.

@pcrespov pcrespov enabled auto-merge (squash) June 6, 2023 19:14
@pcrespov pcrespov merged commit b130801 into ITISFoundation:master Jun 6, 2023
@pcrespov pcrespov deleted the is4071/mypy-integration-library branch June 6, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:ooil integration-library or ooil t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants