-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ webserver
: fixes mypy issues in resource-manager
plugin
#4327
♻️ webserver
: fixes mypy issues in resource-manager
plugin
#4327
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4327 +/- ##
=========================================
+ Coverage 68.5% 78.9% +10.4%
=========================================
Files 419 371 -48
Lines 20996 19239 -1757
Branches 173 0 -173
=========================================
+ Hits 14385 15193 +808
+ Misses 6562 4046 -2516
+ Partials 49 0 -49
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 👍 yes i will take care of the projects plugin
services/web/server/src/simcore_service_webserver/application_settings.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/long_running_tasks.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/resource_manager/registry.py
Show resolved
Hide resolved
@pcrespov I will try to put some work into the exporter this sprint. |
deb23d1
to
820e2e3
Compare
Code Climate has analyzed commit 820e2e3 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed!
|
What do these changes do?
webserver
pluginresource_manager
webserver
except forprojects
after this PR is in?exporter
after this PR is in?rest
as soon as 🐛RabbitMQ: Auto reconnect when state goes bad #4316 merges.Related issue/s
How to test