Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ webserver: fixes mypy issues in resource-manager plugin #4327

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jun 6, 2023

What do these changes do?

  • ♻️ fixes mypy issues in webserver plugin resource_manager
  • ♻️ fixes all mypy issues in webserver except for
make mypy | grep -v -E "exporter|projects|rest_"

Related issue/s

How to test

cd services/web/server
make install-dev
make mypy | grep -v -E "exporter|projects|rest_"

@pcrespov pcrespov self-assigned this Jun 6, 2023
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Jun 6, 2023
@pcrespov pcrespov added this to the Watermelon milestone Jun 6, 2023
@pcrespov pcrespov added the a:webserver issue related to the webserver service label Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #4327 (820e2e3) into master (969de87) will increase coverage by 10.4%.
The diff coverage is 92.9%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4327      +/-   ##
=========================================
+ Coverage    68.5%   78.9%   +10.4%     
=========================================
  Files         419     371      -48     
  Lines       20996   19239    -1757     
  Branches      173       0     -173     
=========================================
+ Hits        14385   15193     +808     
+ Misses       6562    4046    -2516     
+ Partials       49       0      -49     
Flag Coverage Δ
integrationtests 60.1% <67.6%> (-7.8%) ⬇️
unittests 86.2% <92.9%> (-6.3%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e_service_webserver/login/handlers_confirmation.py 90.5% <50.0%> (+44.2%) ⬆️
...ce_webserver/studies_dispatcher/_studies_access.py 91.1% <50.0%> (+61.9%) ⬆️
.../simcore_service_webserver/application_settings.py 98.2% <83.3%> (+17.7%) ⬆️
...src/simcore_service_webserver/activity/handlers.py 93.1% <100.0%> (+63.7%) ⬆️
...re_service_webserver/application_settings_utils.py 97.9% <100.0%> (+5.2%) ⬆️
...rc/simcore_service_webserver/long_running_tasks.py 100.0% <100.0%> (+29.1%) ⬆️
...src/simcore_service_webserver/rabbitmq_settings.py 100.0% <100.0%> (ø)
...mcore_service_webserver/resource_manager/plugin.py 100.0% <100.0%> (ø)
...ore_service_webserver/resource_manager/registry.py 98.7% <100.0%> (+3.9%) ⬆️
...ce_webserver/resource_manager/websocket_manager.py 97.6% <100.0%> (+21.7%) ⬆️
... and 4 more

... and 228 files with indirect coverage changes

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍 yes i will take care of the projects plugin

@GitHK
Copy link
Contributor

GitHK commented Jun 7, 2023

@pcrespov I will try to put some work into the exporter this sprint.

@pcrespov pcrespov enabled auto-merge (squash) June 7, 2023 09:33
@pcrespov pcrespov force-pushed the is7071/mypy-webserver-resource-manager branch from deb23d1 to 820e2e3 Compare June 7, 2023 10:51
@codeclimate
Copy link

codeclimate bot commented Jun 7, 2023

Code Climate has analyzed commit 820e2e3 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov merged commit bf838aa into ITISFoundation:master Jun 7, 2023
@pcrespov pcrespov deleted the is7071/mypy-webserver-resource-manager branch June 8, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants