-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ webserver
: fixes mypy issues in projects
plugin (2/2)
#4328
♻️ webserver
: fixes mypy issues in projects
plugin (2/2)
#4328
Conversation
webserver
: fixes mypy issues in projects
plugin (2/2)
Codecov Report
@@ Coverage Diff @@
## master #4328 +/- ##
=========================================
- Coverage 85.6% 84.5% -1.1%
=========================================
Files 939 392 -547
Lines 39783 20427 -19356
Branches 993 173 -820
=========================================
- Hits 34056 17266 -16790
+ Misses 5503 3112 -2391
+ Partials 224 49 -175
Flags with carried forward coverage won't be shown. Click here to find out more.
|
services/web/server/src/simcore_service_webserver/projects/utils.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Closer to fully "mypyfied" :-)).
Please not my suggestion regarding _InputSchemaConfig
services/web/server/src/simcore_service_webserver/projects/_handlers_crud.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_handlers_project_ports.py
Outdated
Show resolved
Hide resolved
Code Climate has analyzed commit 7185e9b and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed!
|
What do these changes do?
webserver
: fixes mypy issues inprojects
pluginsrc/simcore_service_webserver/projects/_db_utils.py:62:52: error: "<typing special form>" has no attribute "__args__" [attr-defined]
src/simcore_service_webserver/projects/_handlers_crud.py:81:5: error: Required dynamic aliases disallowed [pydantic-alias]
Related issue/s
How to test
DevOps Checklist