Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ webserver: fixes mypy issues in projects plugin (2/2) #4328

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Jun 7, 2023

What do these changes do?

  • ♻️ webserver: fixes mypy issues in projects plugin
  • I put type ignore for two cases (let me know whether you have a better idea):
    • src/simcore_service_webserver/projects/_db_utils.py:62:52: error: "<typing special form>" has no attribute "__args__" [attr-defined]
    • src/simcore_service_webserver/projects/_handlers_crud.py:81:5: error: Required dynamic aliases disallowed [pydantic-alias]

Related issue/s

How to test

cd services/web/server
make install-dev
make mypy | grep "/projects/"

DevOps Checklist

@matusdrobuliak66 matusdrobuliak66 changed the title fix mypy issues in projects plugin ♻️ webserver: fixes mypy issues in projects plugin (2/2) Jun 7, 2023
@matusdrobuliak66 matusdrobuliak66 self-assigned this Jun 7, 2023
@matusdrobuliak66 matusdrobuliak66 added the t:maintenance Some planned maintenance work label Jun 7, 2023
@matusdrobuliak66 matusdrobuliak66 added this to the Watermelon milestone Jun 7, 2023
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review June 7, 2023 07:09
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #4328 (7185e9b) into master (94fbf29) will decrease coverage by 1.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4328      +/-   ##
=========================================
- Coverage    85.6%   84.5%    -1.1%     
=========================================
  Files         939     392     -547     
  Lines       39783   20427   -19356     
  Branches      993     173     -820     
=========================================
- Hits        34056   17266   -16790     
+ Misses       5503    3112    -2391     
+ Partials      224      49     -175     
Flag Coverage Δ
integrationtests 68.2% <85.2%> (+0.2%) ⬆️
unittests 86.2% <100.0%> (+3.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e_service_webserver/projects/_crud_create_utils.py 96.8% <100.0%> (ø)
...rc/simcore_service_webserver/projects/_db_utils.py 97.1% <100.0%> (+<0.1%) ⬆️
...mcore_service_webserver/projects/_handlers_crud.py 82.0% <100.0%> (+<0.1%) ⬆️
...vice_webserver/projects/_handlers_project_nodes.py 83.5% <100.0%> (+<0.1%) ⬆️
...vice_webserver/projects/_handlers_project_ports.py 94.3% <100.0%> (+0.2%) ⬆️
...c/simcore_service_webserver/projects/_permalink.py 97.5% <100.0%> (ø)
...erver/src/simcore_service_webserver/projects/db.py 96.6% <100.0%> (+<0.1%) ⬆️
...ver/src/simcore_service_webserver/projects/lock.py 95.0% <100.0%> (+0.1%) ⬆️
...er/src/simcore_service_webserver/projects/utils.py 86.8% <100.0%> (ø)

... and 623 files with indirect coverage changes

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Closer to fully "mypyfied" :-)).
Please not my suggestion regarding _InputSchemaConfig

@matusdrobuliak66 matusdrobuliak66 requested a review from GitHK June 12, 2023 04:29
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) June 12, 2023 04:30
@codeclimate
Copy link

codeclimate bot commented Jun 12, 2023

Code Climate has analyzed commit 7185e9b and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants