♻️ nodeports accepts folders #4447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
June 16, 2023 14:32
GitHK
commented
Jul 13, 2023
packages/settings-library/src/settings_library/utils_r_clone.py
Outdated
Show resolved
Hide resolved
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
packages/simcore-sdk/src/simcore_sdk/node_ports_v2/port_utils.py
Outdated
Show resolved
Hide resolved
|
Code Climate has analyzed commit fa4fe1f and detected 0 issues on this pull request. View more on Code Climate. |
|
Kudos, SonarCloud Quality Gate passed!
|
sanderegg
reviewed
Jul 18, 2023
sanderegg
reviewed
Jul 18, 2023
sanderegg
reviewed
Jul 18, 2023
sanderegg
reviewed
Jul 18, 2023
sanderegg
reviewed
Jul 18, 2023
sanderegg
reviewed
Jul 18, 2023
sanderegg
reviewed
Jul 18, 2023
sanderegg
reviewed
Jul 18, 2023
1 task
This was referenced Jul 19, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Allows
nodeportsto deal with folders. Service states are still treated as zip files.rclonercloneis used for uploading and downloading folders. It is no longer used to only upload files.rcloneprogress is now captured parsed and send to the frontendrclonewas tuned down to not overwhelm the nodes where it is runningrcloneversion updateNOTE: this PR will not change how nodeports is used by the dy-sidecar and the desk sidecar
Related issue/s
storagehandles directories 🚨 #4377How to test
DevOps Checklist