♻️ Maintenance: Fixes and removing deprecated functionality in servicelib

[pcrespov]

What do these changes do?

Big cleanup of deprecated/unused code in servicelib

• 🗑️ Removing dependencies to attr (replaced by dataclass)
• 🗑️ Removing deprecated, duplicated or unused functionality
  • submodules as servicelib.aiohttp.rest_* ... which are related openapi-core
  • functionality resources
• 🐛 Fixes bugs detected by mypy
• ⚗️ SEE test_application.py app events
  - found some pitfalls on cleanup of client and fire&forget events!

Related issue/s

• Implementing ⚗️ web-server refactoring backlog #2008

How to test

• in-place

DevOps

None

[codecov]

Codecov Report

Merging #4470 (7f5b986) into master (9e9e234) will decrease coverage by 15.7%.
The diff coverage is 69.1%.

@@            Coverage Diff            @@
##           master   #4470      +/-   ##
=========================================
- Coverage    86.2%   70.5%   -15.7%     
=========================================
  Files        1016     719     -297     
  Lines       43278   30978   -12300     
  Branches     1021     536     -485     
=========================================
- Hits        37340   21866   -15474     
- Misses       5704    8982    +3278     
+ Partials      234     130     -104     

Flag	Coverage Δ
integrationtests	61.3% <57.8%> (-6.9%)	⬇️
unittests	70.0% <69.1%> (-13.9%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...library/src/servicelib/aiohttp/dev_error_logger.py	0.0% <0.0%> (ø)
...library/src/servicelib/aiohttp/monitor_services.py	0.0% <0.0%> (ø)
...ckages/service-library/src/servicelib/resources.py	0.0% <0.0%> (ø)
...rc/simcore_service_webserver/diagnostics/plugin.py	55.5% <0.0%> (-44.5%)	⬇️
...ice_webserver/notifications/_rabbitmq_consumers.py	51.3% <ø> (-47.3%)	⬇️
...erver/src/simcore_service_webserver/rest/plugin.py	86.8% <20.0%> (-4.6%)	⬇️
...library/src/servicelib/aiohttp/openapi_wrappers.py	51.9% <25.0%> (-20.8%)	⬇️
...rary/src/servicelib/aiohttp/requests_validation.py	84.4% <33.3%> (-2.0%)	⬇️
...mcore_service_webserver/diagnostics/_monitoring.py	61.9% <33.3%> (-38.1%)	⬇️
.../service-library/src/servicelib/aiohttp/openapi.py	64.8% <50.0%> (-1.0%)	⬇️
... and 24 more

... and 500 files with indirect coverage changes

[codeclimate]

Code Climate has analyzed commit 8cdb35d and detected 0 issues on this pull request.

View more on Code Climate.

[matusdrobuliak66]

looking good 👍

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[GitHK]

Nice, find some questions below.

[mrnicegyu11]

thanks!