Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ removing code that is no longer required #4478

Merged
merged 2 commits into from
Jul 10, 2023
Merged

♻️ removing code that is no longer required #4478

merged 2 commits into from
Jul 10, 2023

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jul 10, 2023 •
edited
Loading

What do these changes do?

Field can_save, can no longer be None, removing all relative tests and validation code.

Related issue/s

How to test

DevOps Checklist

@GitHK GitHK self-assigned this Jul 10, 2023
@GitHK GitHK added this to the Watermelon milestone Jul 10, 2023
@GitHK GitHK added the t:maintenance Some planned maintenance work label Jul 10, 2023
@GitHK GitHK marked this pull request as ready for review July 10, 2023 13:37
@GitHK GitHK requested review from sanderegg and pcrespov as code owners July 10, 2023 13:37
@GitHK GitHK requested a review from matusdrobuliak66 July 10, 2023 13:37
@codeclimate
Copy link

codeclimate bot commented Jul 10, 2023

Code Climate has analyzed commit b1f34e9 and detected 0 issues on this pull request.

View more on Code Climate.

@GitHK GitHK enabled auto-merge (squash) July 10, 2023 13:53
@GitHK GitHK merged commit 49b6e0d into ITISFoundation:master Jul 10, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@GitHK GitHK deleted the remove-code-4202 branch July 11, 2023 06:08
This was referenced Jul 19, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@sanderegg sanderegg Awaiting requested review from sanderegg sanderegg is a code owner

Assignees

@GitHK GitHK

Labels
t:maintenance Some planned maintenance work
Projects
None yet
Milestone
Watermelon
Development

Successfully merging this pull request may close these issues.

♻️ remove code once #4202 hits production
3 participants
@GitHK @pcrespov @matusdrobuliak66