Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️🗃️ Is1004/modify resource tracker backend after container label changes #4488

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Jul 11, 2023

@matusdrobuliak66 matusdrobuliak66 self-assigned this Jul 11, 2023
@matusdrobuliak66 matusdrobuliak66 added the a:resource-usage-tracker resource usage tracker service label Jul 11, 2023
@matusdrobuliak66 matusdrobuliak66 added this to the Watermelon milestone Jul 11, 2023
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review July 11, 2023 13:27
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #4488 (1006207) into master (241d018) will increase coverage by 2.2%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4488     +/-   ##
========================================
+ Coverage    86.4%   88.7%   +2.2%     
========================================
  Files        1013     727    -286     
  Lines       43225   33509   -9716     
  Branches     1006     361    -645     
========================================
- Hits        37381   29731   -7650     
+ Misses       5612    3686   -1926     
+ Partials      232      92    -140     
Flag Coverage Δ
integrationtests 68.1% <ø> (+0.1%) ⬆️
unittests 87.2% <ø> (+3.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 304 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 changed the title ♻️ Is1004/modify resource tracker backend after container label changes ♻️🗃️ Is1004/modify resource tracker backend after container label changes Jul 11, 2023
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff, please if you find the time remove the double underscore, this is the stuff devops nightmares are made from. The rest is super awesome :--)

@codeclimate
Copy link

codeclimate bot commented Jul 11, 2023

Code Climate has analyzed commit 1006207 and detected 0 issues on this pull request.

View more on Code Climate.

@pcrespov pcrespov merged commit a0dd8ad into ITISFoundation:master Jul 11, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:resource-usage-tracker resource usage tracker service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify backend of resource tracker based on consolidated container labels
3 participants