Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Frontend: Announcements #4489

Merged
merged 57 commits into from
Jul 12, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jul 11, 2023

What do these changes do?

Announcements are now defined in the backend (redis).

Depending on their definition, they can be placed in:

  • Login page: title + description, between the product logo and the form, strong-button like text area
  • Ribbon: title + description, right below the warnings, also with a strong button appearance. This widget can be closed and/or hidden forever (localStorage)
  • User Menu: title, when clicking on it the link will be opened (it will actually will be shown if a link is provided)

Demo with the following announcement:
image
Announcement

Related issue/s

closes #4423
related to https://git.speag.com/oSparc/ti-solutions/-/issues/21

How to test

DevOps Checklist

@odeimaiz odeimaiz self-assigned this Jul 11, 2023
@odeimaiz odeimaiz changed the title frontend part ✨ Frontend: Announcements Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #4489 (de452b8) into master (eb5e00b) will decrease coverage by 0.2%.
The diff coverage is 97.9%.

❗ Current head de452b8 differs from pull request most recent head 1b98960. Consider uploading reports for the commit 1b98960 to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4489     +/-   ##
========================================
- Coverage    86.4%   86.3%   -0.2%     
========================================
  Files        1013    1018      +5     
  Lines       43218   43305     +87     
  Branches     1006    1006             
========================================
+ Hits        37370   37389     +19     
- Misses       5616    5684     +68     
  Partials      232     232             
Flag Coverage Δ
integrationtests 66.4% <63.2%> (-1.6%) ⬇️
unittests 84.1% <97.9%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ges/settings-library/src/settings_library/redis.py 0.0% <0.0%> (ø)
.../web/server/src/simcore_service_webserver/redis.py 95.6% <92.8%> (+0.1%) ⬆️
...rc/simcore_service_webserver/announcements/_api.py 100.0% <100.0%> (ø)
...mcore_service_webserver/announcements/_handlers.py 100.0% <100.0%> (ø)
...simcore_service_webserver/announcements/_models.py 100.0% <100.0%> (ø)
.../simcore_service_webserver/announcements/_redis.py 100.0% <100.0%> (ø)
.../simcore_service_webserver/announcements/plugin.py 100.0% <100.0%> (ø)
...erver/src/simcore_service_webserver/application.py 98.0% <100.0%> (+<0.1%) ⬆️
.../simcore_service_webserver/application_settings.py 98.2% <100.0%> (+<0.1%) ⬆️

... and 11 files with indirect coverage changes

@codeclimate
Copy link

codeclimate bot commented Jul 12, 2023

Code Climate has analyzed commit 1b98960 and detected 0 issues on this pull request.

View more on Code Climate.

@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:✨new-feature labels Jul 12, 2023
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

What happens if there are more than one announcements? (If we plan to support this use-case).

Maybe for the future: we could have a kind of News & Events menu (under the user menu?), like many websites have (e.g. this one).

@odeimaiz odeimaiz merged commit 92fbd1b into ITISFoundation:master Jul 12, 2023
@odeimaiz
Copy link
Member Author

@elisabettai
Currently we support maximum one announcement per product and a small widget is placed to show these rather short texts.
If we envision to have multiple announcements, we could extend the current frontend infrastructure, but I would personally move to a static website or section dedicated to the announcements, with richer widgets with pictures and everything, like the one you linked.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odeimaiz odeimaiz added this to the Sundae milestone Jul 12, 2023
pcrespov pushed a commit that referenced this pull request Jul 13, 2023
@odeimaiz odeimaiz deleted the feature/fend-announcements branch August 20, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants