-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Frontend: Announcements #4489
✨ Frontend: Announcements #4489
Conversation
…c-simcore into feature/fend-announcements
Codecov Report
@@ Coverage Diff @@
## master #4489 +/- ##
========================================
- Coverage 86.4% 86.3% -0.2%
========================================
Files 1013 1018 +5
Lines 43218 43305 +87
Branches 1006 1006
========================================
+ Hits 37370 37389 +19
- Misses 5616 5684 +68
Partials 232 232
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Code Climate has analyzed commit 1b98960 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool!
What happens if there are more than one announcements? (If we plan to support this use-case).
Maybe for the future: we could have a kind of News & Events menu (under the user menu?), like many websites have (e.g. this one).
@elisabettai |
Kudos, SonarCloud Quality Gate passed! |
What do these changes do?
Announcements are now defined in the backend (redis).
Depending on their definition, they can be placed in:
title
+description
, between the product logo and the form, strong-button like text areatitle
+description
, right below the warnings, also with a strong button appearance. This widget can be closed and/or hidden forever (localStorage)title
, when clicking on it the link will be opened (it will actually will be shown if a link is provided)Demo with the following announcement:
Related issue/s
closes #4423
related to https://git.speag.com/oSparc/ti-solutions/-/issues/21
How to test
DevOps Checklist