🐛 fixing flaky test test_checked_once_task_is_auto_removed #4527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 21, 2023 15:57
Codecov Report
@@ Coverage Diff @@
## master #4527 +/- ##
========================================
- Coverage 86.5% 84.4% -2.2%
========================================
Files 1008 824 -184
Lines 43128 36582 -6546
Branches 998 530 -468
========================================
- Hits 37337 30892 -6445
- Misses 5561 5562 +1
+ Partials 230 128 -102
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sanderegg
reviewed
Jul 21, 2023
packages/service-library/tests/long_running_tasks/test_long_running_tasks_task.py
Outdated
Show resolved
Hide resolved
packages/service-library/tests/long_running_tasks/test_long_running_tasks_task.py
Outdated
Show resolved
Hide resolved
pcrespov
reviewed
Jul 21, 2023
pcrespov
approved these changes
Jul 21, 2023
packages/service-library/tests/long_running_tasks/test_long_running_tasks_task.py
Outdated
Show resolved
Hide resolved
packages/service-library/tests/long_running_tasks/test_long_running_tasks_task.py
Outdated
Show resolved
Hide resolved
|
Code Climate has analyzed commit c592fea and detected 0 issues on this pull request. View more on Code Climate. |
|
Kudos, SonarCloud Quality Gate passed!
|
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Very pesky edge case
FAILED tests/long_running_tasks/test_long_running_tasks_task.py::test_checked_once_task_is_auto_removed - Failed: DID NOT RAISE <class 'servicelib.long_running_tasks._errors.TaskNotFoundError'>Pytest raises a BaseException that is not caught and retried by tenacity.
Also the test logic was not 100% accurate
Related issue/s
How to test
DevOps Checklist