Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨RabbitMQ: allow secure rabbit protocol (⚠️DevOPS) #4567

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Aug 2, 2023

What do these changes do?

This PR allows the usage of an external secured RabbitMQ service via a new ENV variable RABBIT_SECURE
⚠️: New RABBIT_SECURE ENV which is a boolean, may be anything that pydantic transfers to True/False (e.g. "true", "false", 0, 1, etc...)

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg added the a:infra+ops maintenance of infrastructure or operations (discussed in retro) label Aug 2, 2023
@sanderegg sanderegg added this to the Sundae milestone Aug 2, 2023
@sanderegg sanderegg self-assigned this Aug 2, 2023
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sanderegg sanderegg changed the title ✨RabbitMQ: allow secure rabbit protocol ✨RabbitMQ: allow secure rabbit protocol (⚠️DevOPS) Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #4567 (f1b2a56) into master (c2e2ec2) will decrease coverage by 3.2%.
The diff coverage is 33.3%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4567      +/-   ##
=========================================
- Coverage    88.1%   84.9%    -3.2%     
=========================================
  Files         552    1008     +456     
  Lines       27498   43200   +15702     
  Branches      534    1014     +480     
=========================================
+ Hits        24227   36718   +12491     
- Misses       3147    6263    +3116     
- Partials      124     219      +95     
Flag Coverage Δ
integrationtests 59.6% <0.0%> (-7.3%) ⬇️
unittests 84.1% <33.3%> (-2.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...es/settings-library/src/settings_library/rabbit.py 0.0% <0.0%> (ø)
...es/dynamic_sidecar/docker_service_specs/sidecar.py 81.6% <ø> (-6.2%) ⬇️
...re_service_webserver/application_settings_utils.py 97.8% <100.0%> (+<0.1%) ⬆️

... and 509 files with indirect coverage changes

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super thank you

@mrnicegyu11
Copy link
Member

@sanderegg sanderegg force-pushed the maintenance/allow-secure-rabbit-protocol branch from 61f0bec to f1b2a56 Compare August 2, 2023 14:07
@sanderegg sanderegg enabled auto-merge (squash) August 2, 2023 14:08
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Aug 2, 2023

Code Climate has analyzed commit f1b2a56 and detected 0 issues on this pull request.

View more on Code Climate.

@sanderegg sanderegg disabled auto-merge August 2, 2023 14:49
@sanderegg sanderegg merged commit 5318d0f into ITISFoundation:master Aug 2, 2023
@sanderegg sanderegg deleted the maintenance/allow-secure-rabbit-protocol branch August 2, 2023 14:49
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:infra+ops maintenance of infrastructure or operations (discussed in retro)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants