Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Dynamic services backend: connect to resource tracking via RabbitMQ #4590

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Aug 8, 2023

What do these changes do?

When starting a dynamic-sidecar it will publish messages used by the resource tracking. Messages like started, stopped and heart_beat are sent based on the state of the user services.
For more details regarding the expected sequence of events have a look at services/dynamic-sidecar/tests/unit/test_api_workflow_service_metrics.py.

  • ✨ when starting a dynamic-sidecar it is required to provide a new object consenting parameters required for the metrics CreateServiceMetricsAdditionalParams
  • addressed possible flakiness in services/dynamic-sidecar/tests/unit/test_api_containers_long_running_tasks.py

Bonus:

Related issue/s

How to test

DevOps Checklist

@GitHK GitHK self-assigned this Aug 8, 2023
@GitHK GitHK added the a:dynamic-sidecar dynamic-sidecar service label Aug 8, 2023
@GitHK GitHK added this to the Sundae milestone Aug 8, 2023
@GitHK GitHK changed the title ✨ dynamic-sidecar keeps send out billing information ✨ Dynamic services backend: connect to resource tracking via RabbitMQ Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #4590 (10d423f) into master (3e6b521) will increase coverage by 5.6%.
The diff coverage is 95.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4590      +/-   ##
=========================================
+ Coverage    81.5%   87.2%    +5.6%     
=========================================
  Files         530     945     +415     
  Lines       19663   41863   +22200     
  Branches      655     530     -125     
=========================================
+ Hits        16036   36505   +20469     
- Misses       3489    5238    +1749     
+ Partials      138     120      -18     
Flag Coverage Δ
integrationtests 65.2% <58.8%> (?)
unittests 84.6% <84.2%> (+3.0%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ary/src/settings_library/resource_usage_tracker.py 0.0% <0.0%> (ø)
...ervice_dynamic_sidecar/modules/outputs/__init__.py 100.0% <ø> (ø)
...imcore_service_dynamic_sidecar/core/application.py 97.0% <75.0%> (-1.0%) ⬇️
...imcore_service_dynamic_sidecar/core/docker_logs.py 91.1% <83.3%> (-1.1%) ⬇️
...c_sidecar/scheduler/_core/_events_user_services.py 92.0% <92.0%> (ø)
...mcore_service_dynamic_sidecar/core/docker_utils.py 92.9% <95.5%> (+15.4%) ⬆️
...dynamic_sidecar/modules/resource_tracking/_core.py 96.0% <96.0%> (ø)
...ls-library/src/models_library/services_creation.py 100.0% <100.0%> (ø)
...or-v2/src/simcore_service_director_v2/constants.py 100.0% <100.0%> (ø)
...2/src/simcore_service_director_v2/core/settings.py 97.5% <100.0%> (ø)
... and 14 more

... and 562 files with indirect coverage changes

@GitHK GitHK requested a review from matusdrobuliak66 August 29, 2023 13:31
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GitHK GitHK requested review from pcrespov and sanderegg September 4, 2023 12:07
@codeclimate
Copy link

codeclimate bot commented Sep 6, 2023

Code Climate has analyzed commit 10d423f and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) September 6, 2023 07:01
@matusdrobuliak66 matusdrobuliak66 merged commit 0357981 into ITISFoundation:master Sep 6, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dynamic-sidecar dynamic-sidecar service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic Sidecar (dynamic services) send message Broken docker progress parsing when pulling images
4 participants