-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Dynamic services backend: connect to resource tracking via RabbitMQ #4590
✨ Dynamic services backend: connect to resource tracking via RabbitMQ #4590
Conversation
…-resource-tracking
Codecov Report
@@ Coverage Diff @@
## master #4590 +/- ##
=========================================
+ Coverage 81.5% 87.2% +5.6%
=========================================
Files 530 945 +415
Lines 19663 41863 +22200
Branches 655 530 -125
=========================================
+ Hits 16036 36505 +20469
- Misses 3489 5238 +1749
+ Partials 138 120 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…-resource-tracking
…-resource-tracking
…-resource-tracking
…-resource-tracking
…-resource-tracking
packages/models-library/src/models_library/services_creation.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Code Climate has analyzed commit 10d423f and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed!
|
What do these changes do?
When starting a dynamic-sidecar it will publish messages used by the resource tracking. Messages like
started
,stopped
andheart_beat
are sent based on the state of the user services.For more details regarding the expected sequence of events have a look at
services/dynamic-sidecar/tests/unit/test_api_workflow_service_metrics.py
.dynamic-sidecar
it is required to provide a new object consenting parameters required for the metricsCreateServiceMetricsAdditionalParams
services/dynamic-sidecar/tests/unit/test_api_containers_long_running_tasks.py
Bonus:
Related issue/s
How to test
DevOps Checklist