Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comp backend/clusters creation functionalities #4602

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Aug 10, 2023

What do these changes do?

  • added remote debugging via debugpy facilities
  • moved dask-gateway fixtures into pytest-simcore package
  • clusters-keeper now uses dask client to connect with created dask-gateway
  • clusters-keeper defines RPC entrypoint to clusters-keeper.get_or_create a cluster for a user/wallet
  • background task that auto-terminates external AWS clusters created by clusters-keeper based on:
    • terminate any cluster where *SERVICE_TRACKING_HEARTBEAT * CLUSTERS_KEEPER_MAX_MISSED_HEARTBEATS_BEFORE_CLUSTER_TERMINATION
    • set last heartbeat defined as a cluster exist in the dask-gateway, and there are tasks being processed or datasets saved in the cluster
  • auto-create docker swarm on newly created primary cluster machine
  • auto-start osparc-dask-gateway on newly created primary cluster machine

Next tasks

  • potentially completely remove dask-gateway and replace with standard dask-scheduler/worker using tls protocol
  • modify autoscaling service to understand dask tasks and create machines for the demand
  • start autoscaling
  • connect with director-v2

Related issue/s

How to test

DevOps Checklist

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #4602 (dda0460) into master (df7114d) will decrease coverage by 2.0%.
The diff coverage is 94.7%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4602     +/-   ##
========================================
- Coverage    85.3%   83.3%   -2.0%     
========================================
  Files        1077    1086      +9     
  Lines       45240   45518    +278     
  Branches     1027    1027             
========================================
- Hits        38611   37938    -673     
- Misses       6409    7360    +951     
  Partials      220     220             
Flag Coverage Δ
integrationtests 38.7% <ø> (-19.9%) ⬇️
unittests 83.1% <94.7%> (-1.3%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rc/simcore_service_clusters_keeper/rpc/clusters.py 46.4% <46.4%> (ø)
...rc/simcore_service_clusters_keeper/modules/dask.py 97.2% <97.2%> (ø)
...eeper/src/simcore_service_clusters_keeper/_meta.py 91.3% <100.0%> (+4.3%) ⬆️
.../src/simcore_service_clusters_keeper/api/health.py 100.0% <100.0%> (ø)
...imcore_service_clusters_keeper/core/application.py 100.0% <100.0%> (ø)
...src/simcore_service_clusters_keeper/core/errors.py 100.0% <100.0%> (ø)
...c/simcore_service_clusters_keeper/core/settings.py 100.0% <100.0%> (ø)
...eper/src/simcore_service_clusters_keeper/models.py 100.0% <100.0%> (ø)
...imcore_service_clusters_keeper/modules/clusters.py 100.0% <100.0%> (ø)
...lusters_keeper/modules/clusters_management_core.py 100.0% <100.0%> (ø)
... and 8 more

... and 76 files with indirect coverage changes

@sanderegg sanderegg force-pushed the comp-backend/clusters-creation-functionalities branch 9 times, most recently from 0334b2c to 99c15e1 Compare August 15, 2023 13:26
@sanderegg sanderegg force-pushed the comp-backend/clusters-creation-functionalities branch 6 times, most recently from cb8b310 to 85da81c Compare August 25, 2023 08:47
@sanderegg sanderegg force-pushed the comp-backend/clusters-creation-functionalities branch 4 times, most recently from ebfaf34 to 6770346 Compare August 29, 2023 10:14
@sanderegg sanderegg force-pushed the comp-backend/clusters-creation-functionalities branch from 6770346 to f66eb93 Compare August 29, 2023 14:01
@sanderegg sanderegg force-pushed the comp-backend/clusters-creation-functionalities branch 3 times, most recently from 8c7decf to 9882f6e Compare September 2, 2023 14:16
@sanderegg sanderegg force-pushed the comp-backend/clusters-creation-functionalities branch from a1f23c6 to dda0460 Compare September 4, 2023 12:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.0% 3.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Sep 4, 2023

Code Climate has analyzed commit dda0460 and detected 0 issues on this pull request.

View more on Code Climate.

@sanderegg sanderegg enabled auto-merge (squash) September 4, 2023 12:51
@sanderegg sanderegg merged commit 4bf6e90 into ITISFoundation:master Sep 4, 2023
@sanderegg sanderegg deleted the comp-backend/clusters-creation-functionalities branch September 4, 2023 13:24
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants