🐛 Hot-fix: Ensure synchronization between projects/workbench and projects_nodes #4617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
requested review from
pcrespov,
GitHK and
matusdrobuliak66
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
|
Code Climate has analyzed commit 669921c and detected 0 issues on this pull request. View more on Code Climate. |
6 tasks
mguidon
approved these changes
Aug 17, 2023
Codecov Report
@@ Coverage Diff @@
## master #4617 +/- ##
=========================================
- Coverage 86.8% 82.5% -4.3%
=========================================
Files 1049 310 -739
Lines 44557 15700 -28857
Branches 1016 0 -1016
=========================================
- Hits 38697 12962 -25735
+ Misses 5632 2738 -2894
+ Partials 228 0 -228
Flags with carried forward coverage won't be shown. Click here to find out more.
|
GitHK
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR fixes the issue with synchronization between the projects table workbench column and the projects_nodes table.
The problem arises due to the following issues:
On node creation the frontend does:
POST /projects/{project_id}/nodesand does not wait for an answerPUT /projects/{project_id}arrives soon after with the new node in the workbench --> works since 1. call is fastOn node deletion the frontend does:
DELETE /projects/{project_id}/nodes/{node_id}and does not wait for an answer although that call is slow when a dynamic service needs to be removed (typically from .5s to several seconds).PUT /projects/{project_id}arrives soon after with the node already removed from the workbench. the call is fast an changes projects/workbench.This is a quick fix that could be applied to production code. the long fix will come after this one.
Also it would make sense that the frontend waits for the node creation/deletion calls before sending PUT calls.
Related issue/s
How to test
DevOps Checklist