-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Add missing email env variables to webserver (:warning: DEVOPS) #4648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4648 +/- ##
========================================
+ Coverage 80.0% 85.8% +5.8%
========================================
Files 1018 1055 +37
Lines 42875 44747 +1872
Branches 1020 1020
========================================
+ Hits 34316 38435 +4119
+ Misses 8330 6083 -2247
Partials 229 229
Flags with carried forward coverage won't be shown. Click here to find out more. |
pcrespov
approved these changes
Aug 23, 2023
GitHK
approved these changes
Aug 23, 2023
matusdrobuliak66
approved these changes
Aug 23, 2023
sanderegg
approved these changes
Aug 24, 2023
mrnicegyu11
approved these changes
Aug 24, 2023
Kudos, SonarCloud Quality Gate passed! |
Code Climate has analyzed commit d90018e and detected 0 issues on this pull request. View more on Code Climate. |
16 tasks
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
buggy, it does not work as expected
High Priority
a totally crucial bug/feature to be fixed asap
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
These changes add 3 email env variable that were missing after Webserver ENV Cleanup. The variables are:
Related issue/s
How to test
Run simcore locally and ensure it starts and
webserver_email
is initialized with the provided variablesDevOps Checklist