Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add missing email env variables to webserver (:warning: DEVOPS) #4648

Merged
merged 7 commits into from
Aug 25, 2023

Conversation

YuryHrytsuk
Copy link
Contributor

What do these changes do?

These changes add 3 email env variable that were missing after Webserver ENV Cleanup. The variables are:

  • SMTP_USERNAME
  • SMTP_PASSWORD
  • SMTP_PROTOCOL

Related issue/s

How to test

Run simcore locally and ensure it starts and webserver_email is initialized with the provided variables

DevOps Checklist

  • Make sure while deploying to production that webserver has SMTP_USERNAME, SMTP_PASSWORD AND SMTP_PROTOCAL variable setup.

@YuryHrytsuk YuryHrytsuk added bug buggy, it does not work as expected High Priority a totally crucial bug/feature to be fixed asap labels Aug 23, 2023
@YuryHrytsuk YuryHrytsuk added this to the Baklava milestone Aug 23, 2023
@YuryHrytsuk YuryHrytsuk self-assigned this Aug 23, 2023
@YuryHrytsuk YuryHrytsuk requested a review from sanderegg as a code owner August 23, 2023 12:01
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #4648 (d90018e) into master (eb6612d) will increase coverage by 5.8%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4648     +/-   ##
========================================
+ Coverage    80.0%   85.8%   +5.8%     
========================================
  Files        1018    1055     +37     
  Lines       42875   44747   +1872     
  Branches     1020    1020             
========================================
+ Hits        34316   38435   +4119     
+ Misses       8330    6083   -2247     
  Partials      229     229             
Flag Coverage Δ
integrationtests 59.6% <ø> (-5.9%) ⬇️
unittests 84.4% <ø> (+6.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 208 files with indirect coverage changes

@YuryHrytsuk YuryHrytsuk enabled auto-merge (squash) August 24, 2023 12:22
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codeclimate
Copy link

codeclimate bot commented Aug 25, 2023

Code Climate has analyzed commit d90018e and detected 0 issues on this pull request.

View more on Code Climate.

@YuryHrytsuk YuryHrytsuk merged commit 833e1c2 into master Aug 25, 2023
@YuryHrytsuk YuryHrytsuk deleted the fix-webserver-email-env branch August 25, 2023 08:23
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug buggy, it does not work as expected High Priority a totally crucial bug/feature to be fixed asap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

♻️ Fix email credentials in staging
6 participants