Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ new API entrypoint web-server:clone_project and drafts api-server:clone_study #4650

Merged
merged 15 commits into from
Aug 24, 2023

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Aug 23, 2023

What do these changes do?

  • new route to clone_project in web-server
    • refactoring since File _crud_handlers.py has 501 lines of code (exceeds 500 allowed).
  • exposes entrypoint for clone_study in api-server.
    • For the sake of clarity, the implementation connecting both entrypoints will be in next PR

Related issue/s

How to test

Driving test in the webserver are

cd services/web/server
pytest -vv tests/unit/with_dbs/02/test_projects_ports_handlers.py::test_clone_project_and_set_inputs
pytest -vv tests/unit/with_dbs/02/test_projects_ports_handlers__clone.py::test_clone_project

DevOps

None

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #4650 (2994be2) into master (9c5e641) will increase coverage by 0.1%.
The diff coverage is 75.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4650     +/-   ##
========================================
+ Coverage    86.6%   86.7%   +0.1%     
========================================
  Files        1054     844    -210     
  Lines       44720   37501   -7219     
  Branches     1019     535    -484     
========================================
- Hits        38732   32548   -6184     
+ Misses       5759    4830    -929     
+ Partials      229     123    -106     
Flag Coverage Δ
integrationtests 65.4% <60.0%> (+1.4%) ⬆️
unittests 83.9% <75.0%> (-0.5%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...c/simcore_service_api_server/api/routes/studies.py 95.1% <60.0%> (-4.9%) ⬇️
...ervice_webserver/projects/_crud_handlers_models.py 66.6% <66.6%> (ø)
...mcore_service_webserver/projects/_crud_api_read.py 97.5% <75.0%> (-0.1%) ⬇️
...rc/servicelib/aiohttp/long_running_tasks/client.py 93.1% <81.2%> (-2.2%) ⬇️
...mcore_service_webserver/projects/_crud_handlers.py 86.4% <93.7%> (+5.5%) ⬆️
...core_service_api_server/api/routes/solvers_jobs.py 76.1% <100.0%> (ø)
...c/simcore_service_api_server/services/webserver.py 89.1% <100.0%> (ø)
...e_service_webserver/projects/_metadata_handlers.py 95.2% <100.0%> (ø)

... and 223 files with indirect coverage changes

@pcrespov pcrespov self-assigned this Aug 23, 2023
@pcrespov pcrespov force-pushed the is4177/projects-job-metadata branch from dcdb571 to 3f207b1 Compare August 23, 2023 17:07
@pcrespov pcrespov changed the title ✨ WIP: Is4177/projects job metadata ✨ new API entrypoint web-server:clone_project and drafts api-server:clone_study Aug 23, 2023
@pcrespov pcrespov marked this pull request as ready for review August 23, 2023 21:18
@pcrespov pcrespov requested a review from bisgaard-itis August 23, 2023 21:28
@pcrespov pcrespov enabled auto-merge (squash) August 23, 2023 21:28
@codeclimate
Copy link

codeclimate bot commented Aug 23, 2023

Code Climate has analyzed commit 2994be2 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.6% 1.6% Duplication

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@pcrespov pcrespov merged commit e1c7636 into ITISFoundation:master Aug 24, 2023
@pcrespov pcrespov deleted the is4177/projects-job-metadata branch August 24, 2023 08:41
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants