Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Usage overview: request per wallet #4688

Merged
merged 27 commits into from
Aug 30, 2023
Merged

✨ Usage overview: request per wallet #4688

merged 27 commits into from
Aug 30, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Aug 30, 2023 •
edited
Loading

What do these changes do?

This PR follows #4666, where the resource-usage endpoint was updated.

Since now that endpoint also support the wallet_id argument, the frontend offers a drop down menu where users can select wallets that are readable. By default, "All Wallets" is selected.

image

Related issue/s

related to ITISFoundation/osparc-issues#1027

How to test

DevOps Checklist

odeimaiz added 15 commits August 16, 2023 11:49
@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:🎨enhancement labels Aug 30, 2023
@odeimaiz odeimaiz added this to the Baklava milestone Aug 30, 2023
@odeimaiz odeimaiz self-assigned this Aug 30, 2023
@odeimaiz odeimaiz changed the title WIP 🎨 Update/containers to services 🎨 Usage overview: request per wallet Aug 30, 2023
@odeimaiz odeimaiz changed the title 🎨 Usage overview: request per wallet ✨ Usage overview: request per wallet Aug 30, 2023
@odeimaiz odeimaiz marked this pull request as ready for review August 30, 2023 12:54
@odeimaiz odeimaiz enabled auto-merge (squash) August 30, 2023 12:54
@odeimaiz odeimaiz disabled auto-merge August 30, 2023 13:03
@codeclimate
Copy link

codeclimate bot commented Aug 30, 2023

Code Climate has analyzed commit cb72681 and detected 0 issues on this pull request.

View more on Code Climate.

elisabettai
elisabettai reviewed Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@elisabettai elisabettai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
I don't know if the screenshot if out-of-date, but the dropdown icon seems in the wrong place. I'd expect it next to the "All wallets" list.

image

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 30, 2023
Merged
@odeimaiz
Copy link
Member Author

Nice! I don't know if the screenshot if out-of-date, but the dropdown icon seems in the wrong place. I'd expect it next to the "All wallets" list.

image

If you click on that button, you will see that it's not related to the dropdown widget, it lets you hide/show columns in the table.

@odeimaiz odeimaiz enabled auto-merge (squash) August 30, 2023 13:50
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odeimaiz odeimaiz merged commit 641ee58 into ITISFoundation:master Aug 30, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 6, 2023
Closed
16 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 13, 2023
Closed
17 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
Closed
50 tasks
@odeimaiz odeimaiz deleted the update/containers-to-services branch August 20, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elisabettai elisabettai elisabettai left review comments

@pcrespov pcrespov pcrespov approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@GitHK GitHK Awaiting requested review from GitHK

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11

@mguidon mguidon Awaiting requested review from mguidon

@sanderegg sanderegg Awaiting requested review from sanderegg

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Milestone
Baklava
Development

Successfully merging this pull request may close these issues.
4 participants
@odeimaiz @elisabettai @pcrespov @matusdrobuliak66