-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Autoscaling: 1st draft on auto-scaling computational clusters #4711
✨Autoscaling: 1st draft on auto-scaling computational clusters #4711
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4711 +/- ##
========================================
+ Coverage 86.6% 86.8% +0.2%
========================================
Files 1188 1191 +3
Lines 49402 49656 +254
Branches 1072 1072
========================================
+ Hits 42825 43145 +320
+ Misses 6342 6276 -66
Partials 235 235
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ed4587c
to
7f96b24
Compare
987c0f3
to
8abcb54
Compare
483bf56
to
de969ca
Compare
3d27a17
to
27acc27
Compare
5f315c5
to
fd81962
Compare
fd81962
to
829cf50
Compare
b8309a9
to
c76f37e
Compare
This reverts commit 2a09725.
7f65c3e
to
ac00578
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from what I can tell
services/autoscaling/src/simcore_service_autoscaling/modules/auto_scaling_mode_computational.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Just left some comments and suggestions. I am curious about a few things
services/autoscaling/src/simcore_service_autoscaling/modules/auto_scaling_task.py
Show resolved
Hide resolved
services/autoscaling/src/simcore_service_autoscaling/modules/dask.py
Outdated
Show resolved
Hide resolved
services/autoscaling/src/simcore_service_autoscaling/modules/dask.py
Outdated
Show resolved
Hide resolved
services/autoscaling/src/simcore_service_autoscaling/utils/computational_scaling.py
Show resolved
Hide resolved
Code Climate has analyzed commit b149147 and detected 0 issues on this pull request. View more on Code Climate. |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
What do these changes do?
This allows the autoscaling service to optionally connect to a dask-scheduler to find out whether it is in need of dask-workers to complete pending jobs.
For context:
details
DASK_MONITORING_URL
for use when autoscaling is to be set in computational mode (NOTE: DASK_MONITORING_URL and NODE_MONITORING settings cannot be both set)EC2_INSTANCES_NAME_PREFIX
defaults to "autoscaling" allows to prefix machines created by the autoscaling serviceRelated issue/s
How to test
otherwise manual testing see
tests/manual/README.md
DevOps Checklist
EC2_INSTANCES_NAME_PREFIX
, which default to "autoscaling" to keep backwards compatibility with dynamic services autoscaling.