Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 correct service type storing in resource usage tracker #4725

Conversation

matusdrobuliak66
Copy link
Contributor

What do these changes do?

  • 🐛 correct service type storing in resource usage tracker

Related issue/s

How to test

DevOps Checklist

@matusdrobuliak66 matusdrobuliak66 added this to the Baklava milestone Sep 7, 2023
@matusdrobuliak66 matusdrobuliak66 self-assigned this Sep 7, 2023
@matusdrobuliak66 matusdrobuliak66 added the a:resource-usage-tracker resource usage tracker service label Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #4725 (5176006) into master (ea391d4) will decrease coverage by 21.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4725      +/-   ##
=========================================
- Coverage    86.9%   65.9%   -21.1%     
=========================================
  Files        1103     497     -606     
  Lines       46283   25051   -21232     
  Branches     1008     190     -818     
=========================================
- Hits        40250   16522   -23728     
- Misses       5809    8482    +2673     
+ Partials      224      47     -177     
Flag Coverage Δ
integrationtests 65.1% <ø> (-0.1%) ⬇️
unittests 88.6% <100.0%> (+3.9%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...usage_tracker/resource_tracker_process_messages.py 90.3% <100.0%> (+0.1%) ⬆️

... and 892 files with indirect coverage changes

📢 Have feedback on the report? Share it here.

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review September 7, 2023 13:07
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) September 7, 2023 13:59
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Sep 8, 2023

Code Climate has analyzed commit 5176006 and detected 0 issues on this pull request.

View more on Code Climate.

@matusdrobuliak66 matusdrobuliak66 merged commit c650797 into ITISFoundation:master Sep 8, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:resource-usage-tracker resource usage tracker service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants