Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨New groups extra properties to use on demand clusters in DB (🗃️) #4736

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Sep 12, 2023

What do these changes do?

  • 🗃️ adds new column use_on_demand_clusters in groups_extra_properties
  • 🗃️ make group_id,product_name a unique constraint in groups_extra_properties

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg added the a:database associated to postgres service and postgres-database package label Sep 12, 2023
@sanderegg sanderegg added this to the the nameless milestone Sep 12, 2023
@sanderegg sanderegg self-assigned this Sep 12, 2023
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx! i like the constraint! thx

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #4736 (851661a) into master (6cd0ce8) will increase coverage by 3.1%.
The diff coverage is 0.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4736     +/-   ##
========================================
+ Coverage    67.0%   70.2%   +3.1%     
========================================
  Files         556     472     -84     
  Lines       26746   24428   -2318     
  Branches      198     190      -8     
========================================
- Hits        17944   17157    -787     
+ Misses       8754    7224   -1530     
+ Partials       48      47      -1     
Flag Coverage Δ
integrationtests 65.2% <0.0%> (+<0.1%) ⬆️
unittests 64.8% <0.0%> (-22.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../server/src/simcore_service_webserver/users/_db.py 68.2% <0.0%> (ø)

... and 154 files with indirect coverage changes

@sanderegg sanderegg force-pushed the comp-backend/allow-groups-to-use-on-demand-clusters branch from f6c23ab to 851661a Compare September 12, 2023 13:52
@codeclimate
Copy link

codeclimate bot commented Sep 12, 2023

Code Climate has analyzed commit 851661a and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sanderegg sanderegg merged commit a399647 into ITISFoundation:master Sep 12, 2023
@sanderegg sanderegg deleted the comp-backend/allow-groups-to-use-on-demand-clusters branch September 12, 2023 15:14
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:database associated to postgres service and postgres-database package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants