Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 Feature: Tour de S4L #4737

Merged
merged 83 commits into from
Sep 27, 2023
Merged

🎨 Feature: Tour de S4L #4737

merged 83 commits into from
Sep 27, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 12, 2023 •
edited
Loading

What do these changes do?

  • Update the terminology to follow rocket's approach
  • Do not show Panddy, or any other animal, next to the guided tours list :(
  • Move the tours to json files to make them more flexible

https://www.youtube.com/watch?v=Yt3p-F2x7rY
GuidedTours

Related issue/s

related to ITISFoundation/osparc-issues#931

How to test

DevOps Checklist

@odeimaiz odeimaiz added this to the the nameless milestone Sep 12, 2023
@odeimaiz odeimaiz self-assigned this Sep 12, 2023
@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:🎨enhancement labels Sep 12, 2023
@odeimaiz odeimaiz changed the title Feature/flexible tours WIP 🎨 Feature/flexible tours Sep 12, 2023
codeclimate[bot]
codeclimate bot reviewed Sep 12, 2023
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 6566 lines exceeds the maximum allowed for the inline comments feature.

codeclimate[bot]
codeclimate bot reviewed Sep 12, 2023
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 6764 lines exceeds the maximum allowed for the inline comments feature.

codeclimate[bot]
codeclimate bot reviewed Sep 12, 2023
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 6766 lines exceeds the maximum allowed for the inline comments feature.

@odeimaiz odeimaiz marked this pull request as ready for review September 27, 2023 09:30
@odeimaiz odeimaiz changed the title WIP 🎨 Feature: Tour de S4L 🎨 Feature: Tour de S4L Sep 27, 2023
mguidon
mguidon approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brawo!

@odeimaiz odeimaiz enabled auto-merge (squash) September 27, 2023 09:39
@pcrespov pcrespov requested a review from cosfor1 September 27, 2023 10:21
pcrespov
pcrespov reviewed Sep 27, 2023
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Cauterets-Cambasque, Puy de Dôme and Grand Colombier

elisabettai
elisabettai approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, no need of user manuals anymore! 🎉
Maybe we could also add an item for the wallets, when everything is ready (and MAYBE mention there that you start to pay when you start a service...)

Can this guided tour be added to osparc.io as well?

@odeimaiz
Copy link
Member Author

🎉 Cauterets-Cambasque, Puy de Dôme and Grand Colombier

Comment of the month 💪

@odeimaiz
Copy link
Member Author

Maybe we could also add an item for the wallets, when everything is ready (and MAYBE mention there that you start to pay when you start a service...)

Definitely. For now, I just stick to the Guided Tours provided by the App Team, but I also think that a Tour de Wallet is required.

Can this guided tour be added to osparc.io as well?

Yes, very easy to add.

@odeimaiz odeimaiz disabled auto-merge September 27, 2023 11:27
cosfor1
cosfor1 approved these changes Sep 27, 2023
View reviewed changes
Copy link

@cosfor1 cosfor1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@odeimaiz odeimaiz enabled auto-merge (squash) September 27, 2023 12:29
@codeclimate
Copy link

codeclimate bot commented Sep 27, 2023

Code Climate has analyzed commit 23ad5fa and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odeimaiz odeimaiz merged commit d1da92e into ITISFoundation:master Sep 27, 2023
@odeimaiz odeimaiz deleted the feature/flexible-tours branch August 20, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov left review comments

@codeclimate codeclimate[bot] codeclimate[bot] left review comments

@elisabettai elisabettai elisabettai approved these changes

@mguidon mguidon mguidon approved these changes

@cosfor1 cosfor1 cosfor1 approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007

@ignapas ignapas Awaiting requested review from ignapas

@GitHK GitHK Awaiting requested review from GitHK

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Milestone
the nameless
Development

Successfully merging this pull request may close these issues.
6 participants
@odeimaiz @elisabettai @pcrespov @mguidon @cosfor1 @matusdrobuliak66