✨ Invitations to register to product 🚨

[pcrespov]

What do these changes do?

Invitation links allows a user to register a new account. The invitation is bound to an email and now also to a product. That means that

• invitations will only allow registration in bound products
• invitations can also be used to add an existing user to a different product (e.g. a user has an account in a deploy with product A and but not B. Now we can create an invitation link to add user to product B as well)
  • WARNING: for the moment there is not check to prevent e.g. commercial users from being invited to non-commercial products)

NOTE that this PR addresses invitations BUT login bound to product is coming in a subsequent PR.

Highlights

• 🎨 webserver.invitations plugin
  • validates invitation.product == current_product
  • validates invitation is used
• webserver.login plugin
  • ♻️ started refactoring towards Controller-Service-Repository (SEE /docs/coding-conventions.md)
• 🐛 fixes order in list_products

Related issue/s

• follows from ♻️🎨 Invitations service responds with product #5007 where invitations service was updated to account for products
• closes Invitations: Bound invitation to product #4546
• relates to Include product name in request state after @login_required #4776

How to test

Driving test is services/web/server/tests/unit/with_dbs/03/invitations/test_invitations.py

• 🚨 needs manual testing
  • PO generate an invitation
  • use it for a new account
  • PO

DevOps

None

[codecov]

Codecov Report

Merging #4739 (d9634d9) into master (163d47f) will decrease coverage by 0.6%.
Report is 1 commits behind head on master.
The diff coverage is 95.2%.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #4739      +/-   ##
=========================================
- Coverage    81.8%   81.3%    -0.6%     
=========================================
  Files        1162     524     -638     
  Lines       48514   26592   -21922     
  Branches      748     198     -550     
=========================================
- Hits        39704   21628   -18076     
+ Misses       8651    4914    -3737     
+ Partials      159      50     -109     

Flag	Coverage Δ
integrationtests	65.0% <60.3%> (+<0.1%)	⬆️
unittests	86.3% <95.2%> (+7.3%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...rc/simcore_service_webserver/invitations/plugin.py	100.0% <100.0%> (+28.5%)	⬆️
...r/src/simcore_service_webserver/login/_auth_api.py	100.0% <100.0%> (ø)
...c/simcore_service_webserver/login/_registration.py	75.0% <100.0%> (+28.9%)	⬆️
...c/simcore_service_webserver/login/handlers_auth.py	97.8% <100.0%> (+33.1%)	⬆️
...erver/src/simcore_service_webserver/login/utils.py	100.0% <100.0%> (+10.6%)	⬆️
...ver/src/simcore_service_webserver/products/_api.py	69.2% <100.0%> (+26.1%)	⬆️
.../src/simcore_service_webserver/products/_events.py	93.6% <100.0%> (+0.1%)	⬆️
...simcore_service_webserver/products/_middlewares.py	100.0% <100.0%> (ø)
...e_service_webserver/login/handlers_registration.py	89.7% <87.5%> (+43.1%)	⬆️
...src/simcore_service_webserver/invitations/_core.py	75.9% <88.2%> (+43.1%)	⬆️

... and 879 files with indirect coverage changes

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
0.0% Duplication

[matusdrobuliak66]

Just wanted to double check with you: Currently when this signal is emited: SIGNAL_ON_USER_CONFIRMATION the default wallet is created for that user in that product, this will be still valid in this new approach of inviting users that are already in the DB to the new product? Thanks

Update: just checked, that yes, the function notify_user_confirmation would still be called which is good, so the wallet should be created 👍

[matusdrobuliak66]

Looking good thanks! Looking forward for the next PR for #4776 , then we can modify the hardcoded s4l in the socketio connection

[GitHK]

Looks good, there are some asserts looking out of place to me

[GitHK]

Thanks!

[codeclimate]

Code Climate has analyzed commit d9634d9 and detected 0 issues on this pull request.

View more on Code Climate.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.6% Duplication