-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ payments
service: implementation of apis and db repos for one-time-payment workflow ⚠️
#4743
✨ payments
service: implementation of apis and db repos for one-time-payment workflow ⚠️
#4743
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4743 +/- ##
========================================
+ Coverage 85.0% 86.8% +1.8%
========================================
Files 1166 1183 +17
Lines 48670 49178 +508
Branches 1065 1065
========================================
+ Hits 41384 42721 +1337
+ Misses 7050 6221 -829
Partials 236 236
Flags with carried forward coverage won't be shown. Click here to find out more.
|
5f8c290
to
020799b
Compare
aecc7c0
to
a64ee60
Compare
56a3de5
to
67f2b8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
services/payments/src/simcore_service_payments/db/payments_transactions_repo.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good. Just some comments.
services/payments/src/simcore_service_payments/api/rest/_acknowledgements.py
Outdated
Show resolved
Hide resolved
services/payments/src/simcore_service_payments/api/rest/_acknowledgements.py
Outdated
Show resolved
Hide resolved
services/payments/src/simcore_service_payments/api/rest/_acknowledgements.py
Outdated
Show resolved
Hide resolved
services/payments/tests/unit/test_db_payments_transactions_repo.py
Outdated
Show resolved
Hide resolved
services/payments/tests/unit/test_services_resource_usage_tracker.py
Outdated
Show resolved
Hide resolved
services/payments/src/simcore_service_payments/api/rest/_acknowledgements.py
Show resolved
Hide resolved
services/payments/src/simcore_service_payments/api/rest/_acknowledgements.py
Outdated
Show resolved
Hide resolved
services/payments/src/simcore_service_payments/db/payments_transactions_repo.py
Outdated
Show resolved
Hide resolved
services/payments/tests/unit/test_db_payments_transactions_repo.py
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Code Climate has analyzed commit 50b2c45 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What do these changes do?
This PR takes the logic for the one-time-payment workflow presently in
web-server
'spayments
plugin and adapts it into thepayments
service. The modules affected are highlighted with arrows in the drawing above. Some details follow:db
: Implements db repository to annotate transactions for the one-time-payment workflowservices/postgres
used to setup engine to postgres servicemodels/db
are pydantic models to handle database dataapi/rpc
: implementsinit_payment
by annotating initiated transaction using the repository aboveapi/rest
: implementsacknowledge_payment
annotated ack transaction using the repository aboveDefaultApiError
scripts/fake_payments_gateway
to match openapi specs provided by our partnersNote that after this PR, the
payments
service will still not be full operational to perform a complete the one-time-payment. For that still needs:web-server
'spayments
plugin side (next PR)payments
service to thefront-end
(not relevant for the moment)Related issue/s
How to test
services/payments/tests/unit/test_services_resource_usage_tracker.py
DevOps
payments
service