Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Profile api server #4754

Merged
merged 22 commits into from
Sep 14, 2023

Conversation

bisgaard-itis
Copy link
Contributor

What do these changes do?

  • Add profiling utility to the api server in development mode. This should be useful for detecting performance bottlenecks.

Related issue/s

  • The performance issues reported by @mguidon

How to test

DevOps Checklist

@bisgaard-itis bisgaard-itis self-assigned this Sep 13, 2023
@bisgaard-itis bisgaard-itis added the t:maintenance Some planned maintenance work label Sep 13, 2023
@bisgaard-itis bisgaard-itis added this to the the nameless milestone Sep 13, 2023
@bisgaard-itis bisgaard-itis marked this pull request as ready for review September 13, 2023 22:30
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #4754 (96553f6) into master (6d223c8) will decrease coverage by 24.4%.
The diff coverage is 65.7%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4754      +/-   ##
=========================================
- Coverage    87.0%   62.6%   -24.4%     
=========================================
  Files        1127     538     -589     
  Lines       46940   26662   -20278     
  Branches     1013     190     -823     
=========================================
- Hits        40860   16709   -24151     
- Misses       5853    9906    +4053     
+ Partials      227      47     -180     
Flag Coverage Δ
integrationtests 60.9% <ø> (-4.4%) ⬇️
unittests 81.9% <65.7%> (-2.9%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...re_service_api_server/core/_profiler_middleware.py 62.8% <62.8%> (ø)
...src/simcore_service_api_server/core/application.py 97.1% <100.0%> (+0.1%) ⬆️

... and 895 files with indirect coverage changes

Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Now lets find the bottleneck

services/api-server/README.md Show resolved Hide resolved
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@pcrespov
Copy link
Member

NOTE: pls check the code smell reported by sonar!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Sep 14, 2023

Code Climate has analyzed commit 96553f6 and detected 0 issues on this pull request.

View more on Code Climate.

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) September 14, 2023 12:32
@bisgaard-itis bisgaard-itis merged commit 254a976 into ITISFoundation:master Sep 14, 2023
@bisgaard-itis bisgaard-itis deleted the profile-api-server branch September 14, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants