♻️ changed director-v2 env var definition in compose spec by making it explicit
#4786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4786 +/- ##
========================================
+ Coverage 85.3% 86.9% +1.6%
========================================
Files 1069 1125 +56
Lines 45212 47245 +2033
Branches 683 1037 +354
========================================
+ Hits 38567 41101 +2534
+ Misses 6490 5911 -579
- Partials 155 233 +78
Flags with carried forward coverage won't be shown. Click here to find out more. |
17 tasks
GitHK
changed the title
director-v2 env var definition in compose spec by making it explicit
matusdrobuliak66
approved these changes
Sep 22, 2023
GitHK
requested review from
sanderegg,
mrnicegyu11 and
YuryHrytsuk
as code owners
|
Code Climate has analyzed commit 47959fa and detected 0 issues on this pull request. View more on Code Climate. |
|
Kudos, SonarCloud Quality Gate passed!
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
New env vars need to be explicitly captured by services. As requested by ops.
NOTE: this looks like garbage, but it produces the expected result. I could not find a proper way of escaping it. @YuryHrytsuk @mrnicegyu11 any ideas? I need to have a default{}if the env var is missing.NOTE: trying to add
{}as a default to an env var in docker-compose.yaml will require you to do something like- ENV_VAR=${ENV_VAR:-{}, notice the missing}at the end. If it is added it will resolve toENV_VAR{}}Related issue/s
dynamic-sidecaradding support formetricsandon_shutdownevents for user services (⚠️OPS) #4697How to test
DevOps Checklist