Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ webserver API: generate invitation #4796

Merged
merged 20 commits into from
Sep 28, 2023

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Sep 27, 2023

What do these changes do?

API to create invitations for PO-role users only
image

  • services/webserver api version: 0.30.0 → 0.31.0.
  • ♻️ services/invitations version: 1.0.1 → 1.0.2

Related issue/s

How to test

  • Driving test
cd services/web/server
pytest -vv tests/unit/with_dbs/03/invitations/test_invitations.py:test_product_owner_generate_invitation
  • all tests in invitations
cd services/invitations
make install-dev
make tests-dev-unit

DevOps

None

@pcrespov pcrespov self-assigned this Sep 27, 2023
@pcrespov pcrespov added this to the the nameless milestone Sep 27, 2023
@pcrespov pcrespov added a:webserver issue related to the webserver service a:api framework api, data schemas, labels Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #4796 (dd3b96a) into master (d1da92e) will increase coverage by 0.5%.
The diff coverage is 96.4%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4796     +/-   ##
========================================
+ Coverage    86.9%   87.4%   +0.5%     
========================================
  Files        1149     968    -181     
  Lines       47946   43190   -4756     
  Branches     1029     501    -528     
========================================
- Hits        41666   37751   -3915     
+ Misses       6047    5322    -725     
+ Partials      233     117    -116     
Flag Coverage Δ
integrationtests 65.0% <64.7%> (-0.1%) ⬇️
unittests 84.8% <96.4%> (+0.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...els_library/api_schemas_invitations/invitations.py 100.0% <100.0%> (ø)
...rc/models_library/api_schemas_webserver/product.py 100.0% <100.0%> (ø)
...ons/src/simcore_service_invitations/api/_health.py 100.0% <100.0%> (ø)
...rc/simcore_service_invitations/api/_invitations.py 100.0% <100.0%> (ø)
...ons/src/simcore_service_invitations/invitations.py 100.0% <100.0%> (+1.3%) ⬆️
...c/simcore_service_webserver/invitations/_client.py 96.4% <100.0%> (-0.2%) ⬇️
...r/src/simcore_service_webserver/invitations/api.py 100.0% <100.0%> (ø)
...rc/simcore_service_webserver/invitations/plugin.py 100.0% <100.0%> (ø)
...c/simcore_service_webserver/login/_registration.py 73.8% <100.0%> (ø)
...e_service_webserver/login/handlers_registration.py 90.1% <100.0%> (ø)
... and 6 more

... and 188 files with indirect coverage changes

@pcrespov pcrespov changed the title ✨ webserver API: generate invitation ✨ webserver API: generate (fake) invitation Sep 27, 2023
@pcrespov pcrespov changed the title ✨ webserver API: generate (fake) invitation ✨ webserver API: generate invitation Sep 27, 2023
@pcrespov pcrespov marked this pull request as ready for review September 27, 2023 22:53
@pcrespov pcrespov requested a review from odeimaiz September 27, 2023 22:57
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@codeclimate
Copy link

codeclimate bot commented Sep 27, 2023

Code Climate has analyzed commit dd3b96a and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! 👍

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@pcrespov pcrespov merged commit d587eb3 into ITISFoundation:master Sep 28, 2023
@pcrespov pcrespov deleted the is4752/api-po-invitations branch September 28, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:api framework api, data schemas, a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants