-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ webserver API: generate invitation #4796
✨ webserver API: generate invitation #4796
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4796 +/- ##
========================================
+ Coverage 86.9% 87.4% +0.5%
========================================
Files 1149 968 -181
Lines 47946 43190 -4756
Branches 1029 501 -528
========================================
- Hits 41666 37751 -3915
+ Misses 6047 5322 -725
+ Partials 233 117 -116
Flags with carried forward coverage won't be shown. Click here to find out more.
|
services/web/server/src/simcore_service_webserver/products/_invitations_handlers.py
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed!
|
Code Climate has analyzed commit dd3b96a and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
What do these changes do?
API to create invitations for PO-role users only
![image](https://private-user-images.githubusercontent.com/32402063/271128850-fc043cda-945f-49a7-8bcb-525c6c35fadd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MjAxNTgsIm5iZiI6MTczODkxOTg1OCwicGF0aCI6Ii8zMjQwMjA2My8yNzExMjg4NTAtZmMwNDNjZGEtOTQ1Zi00OWE3LThiY2ItNTI1YzZjMzVmYWRkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDA5MTczOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ2NmE5NWZjNTE4YTA2NTkzZTYxMjYzMjVjNDg0MjY4MDYxNDM2NTE3MTMxNmE0NDJiZjE2NTViMzVkYzFiOGEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Se_pVP03fihsZtgHyQqKEHZuY0EitqQtHlyeiEcaBzg)
services/webserver api version: 0.30.0 → 0.31.0
.generate_invitation
:POST /v0/invitation:generate
services/invitations version: 1.0.1 → 1.0.2
models_library
Related issue/s
How to test
cd services/web/server pytest -vv tests/unit/with_dbs/03/invitations/test_invitations.py:test_product_owner_generate_invitation
cd services/invitations make install-dev make tests-dev-unit
DevOps
None