⚗️ relaxing check to allow CI to pass #4819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4819 +/- ##
========================================
+ Coverage 65.2% 67.1% +1.9%
========================================
Files 680 493 -187
Lines 30718 25343 -5375
Branches 203 195 -8
========================================
- Hits 20051 17028 -3023
+ Misses 10618 8267 -2351
+ Partials 49 48 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
matusdrobuliak66
approved these changes
Oct 2, 2023
|
Code Climate has analyzed commit 0b3b262 and detected 0 issues on this pull request. View more on Code Climate. |
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Oct 4, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Since the code is used only in the teardown part of the tests and the usage is to keep clean the local development environment. I'm relaxing the construing, it is now allowed to not remove all networks on teardown.
Related issue/s
How to test
DevOps Checklist