Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Frontend: Simpler credits workflow #4846

Merged
merged 18 commits into from
Oct 11, 2023
Merged

✨ Frontend: Simpler credits workflow #4846

merged 18 commits into from
Oct 11, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 10, 2023 •
edited
Loading

What do these changes do?

In order to make the credits workflows as simple as possible:

  • The backend will create a Wallet per user upon registration, therefore the creation of Wallets via the frontend has been removed. Also, we only allow users to buy credits for their personal wallet
  • A Wallet will only have one Accountant -> remove the "Promote to Accountant" option
  • Only allow sharing Wallets/Credits with users. For now, no Organizations.

Related issue/s

How to test

DevOps Checklist

@odeimaiz odeimaiz self-assigned this Oct 10, 2023
@odeimaiz odeimaiz changed the title ✨ Own one wallet ✨ Frontend: Own one wallet Oct 10, 2023
@odeimaiz odeimaiz changed the title ✨ Frontend: Own one wallet ✨ Frontend: Simpler credits workflow Oct 10, 2023
@odeimaiz odeimaiz marked this pull request as ready for review October 10, 2023 13:46
@odeimaiz odeimaiz enabled auto-merge (squash) October 10, 2023 13:47
@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:🎨enhancement labels Oct 10, 2023
matusdrobuliak66
matusdrobuliak66 reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

ignapas
ignapas reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@ignapas ignapas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no wallet after creating a new account... I am probably missing something here. Also, I get a "Credit price could not be fetched" error message
image

@odeimaiz
Copy link
Member Author

I see no wallet after creating a new account... I am probably missing something here. Also, I get a "Credit price could not be fetched" error message image

Backend parts might still be missing.

pcrespov
pcrespov reviewed Oct 10, 2023
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ignapas
ignapas approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@ignapas ignapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree "credit account" sound like the bank's credit account... something that would charge you end of the month with some interest

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codeclimate
Copy link

codeclimate bot commented Oct 11, 2023

Code Climate has analyzed commit 5b9a156 and detected 0 issues on this pull request.

View more on Code Climate.

@odeimaiz odeimaiz merged commit 1d2eed3 into ITISFoundation:master Oct 11, 2023
@odeimaiz odeimaiz added this to the Microhistory milestone Oct 16, 2023
This was referenced Oct 17, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 left review comments

@jsaq007 jsaq007 jsaq007 left review comments

@pcrespov pcrespov pcrespov approved these changes

@ignapas ignapas ignapas approved these changes

@GitHK GitHK Awaiting requested review from GitHK

@elisabettai elisabettai Awaiting requested review from elisabettai

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Milestone
Microhistory
Development

Successfully merging this pull request may close these issues.
5 participants
@odeimaiz @jsaq007 @ignapas @pcrespov @matusdrobuliak66