-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Optional extra_credits in invitations #4850
✨ Optional extra_credits in invitations #4850
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4850 +/- ##
=========================================
+ Coverage 82.9% 84.3% +1.4%
=========================================
Files 724 1040 +316
Lines 25732 41690 +15958
Branches 1063 1063
=========================================
+ Hits 21338 35168 +13830
- Misses 4169 6297 +2128
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more.
|
f7c47c4
to
3f14402
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👍
services/web/server/src/simcore_service_webserver/login/handlers_registration.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/login/_registration.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/login/handlers_confirmation.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merci!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks
3f14402
to
22d7489
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Code Climate has analyzed commit 22d7489 and detected 0 issues on this pull request. View more on Code Climate. |
What do these changes do?
This PR introduces an optional new field
extra_credits: PositiveInt
to invitations that permits a PRODUCT_OWNER user to assign a number of credits to the newly created account's wallet upon confirmation.Extra details
APIs affected are:
services/invitations version: 1.0.2 → 1.1.0
: see openapi.json specsextra_credits
to define an invitationservices/webserver api version: 0.32.0 → 0.33.0
: see openapi.json specsconfirmation.data
column. Loads upon confirmation and passes it to the notification so thewallets._events
can add extra credits in the wallet.Related issue/s
How to test
extraCredits=10
DevOps
None