-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Trying to enhance logging for storage #4867
♻️ Trying to enhance logging for storage #4867
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4867 +/- ##
=========================================
- Coverage 86.8% 65.6% -21.3%
=========================================
Files 1179 542 -637
Lines 48996 27724 -21272
Branches 1065 195 -870
=========================================
- Hits 42567 18198 -24369
- Misses 6193 9477 +3284
+ Partials 236 49 -187
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good, but I agree with @pcrespov that the message should be slightly more informative, otherwise it is the also a bit confusing when reading the logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good, but I agree with @pcrespov that the message should be slightly more informative, otherwise it is the also a bit confusing when reading the logs.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Code Climate has analyzed commit 47fed43 and detected 0 issues on this pull request. View more on Code Climate. |
What do these changes do?
There are some edge cases where we cannot debug 503 errors.
Storage does not log tracebacks and this makes it extra hard.
This will make storage print out tracebacks which might help more with debugging the actual issue.
Related issue/s
How to test
DevOps Checklist