Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Trying to enhance logging for storage #4867

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Oct 16, 2023

What do these changes do?

There are some edge cases where we cannot debug 503 errors.
Storage does not log tracebacks and this makes it extra hard.

This will make storage print out tracebacks which might help more with debugging the actual issue.

Related issue/s

How to test

DevOps Checklist

@GitHK GitHK self-assigned this Oct 16, 2023
@GitHK GitHK added the a:storage issue related to storage service label Oct 16, 2023
@GitHK GitHK added this to the Microhistory milestone Oct 16, 2023
@GitHK GitHK marked this pull request as ready for review October 16, 2023 14:19
@GitHK GitHK requested a review from sanderegg as a code owner October 16, 2023 14:19
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #4867 (47fed43) into master (d5d6998) will decrease coverage by 21.3%.
The diff coverage is 60.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4867      +/-   ##
=========================================
- Coverage    86.8%   65.6%   -21.3%     
=========================================
  Files        1179     542     -637     
  Lines       48996   27724   -21272     
  Branches     1065     195     -870     
=========================================
- Hits        42567   18198   -24369     
- Misses       6193    9477    +3284     
+ Partials      236      49     -187     
Flag Coverage Δ
integrationtests 63.7% <ø> (-1.4%) ⬇️
unittests 90.8% <60.0%> (+6.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rage/src/simcore_service_storage/utils_handlers.py 84.8% <60.0%> (-4.5%) ⬇️

... and 959 files with indirect coverage changes

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but I agree with @pcrespov that the message should be slightly more informative, otherwise it is the also a bit confusing when reading the logs.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but I agree with @pcrespov that the message should be slightly more informative, otherwise it is the also a bit confusing when reading the logs.

@GitHK GitHK requested a review from sanderegg October 17, 2023 05:40
@GitHK GitHK enabled auto-merge (squash) October 17, 2023 06:02
@GitHK GitHK added the t:maintenance Some planned maintenance work label Oct 17, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@codeclimate
Copy link

codeclimate bot commented Oct 17, 2023

Code Climate has analyzed commit 47fed43 and detected 0 issues on this pull request.

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:storage issue related to storage service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants