New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Director-v2 passes the wallet ID to clusters-keeper #4930

Merged

sanderegg merged 1 commit into ITISFoundation:master from sanderegg:comp-backend/connect-walletid-to-clusters-keeper

Oct 26, 2023

Member

sanderegg commented Oct 26, 2023 •

edited

Loading

What do these changes do?

enable passing of wallet ID to the clusters-keeper which is used to name the primary machine in AWS

Related issue/s

How to test

DevOps Checklist

sanderegg added the a:director-v2 label

sanderegg added this to the Microhistory milestone

sanderegg self-assigned this

sanderegg requested review from pcrespov and GitHK as code owners

October 26, 2023 09:38

sanderegg mentioned this pull request

sim4life.io - WP4: Computational backend ITISFoundation/osparc-issues#950

Open

sanderegg requested review from mguidon and matusdrobuliak66

October 26, 2023 09:40

mrnicegyu11 approved these changes

View reviewed changes

Member

mrnicegyu11 left a comment

🥇

codecov bot commented Oct 26, 2023 •

edited

Loading

Codecov Report

Merging #4930 (5f89d36) into master (ebed946) will decrease coverage by 16.2%.
The diff coverage is 100.0%.

❗ Current head 5f89d36 differs from pull request most recent head 2d6e0fb. Consider uploading reports for the commit 2d6e0fb to get more accurate results

@@            Coverage Diff            @@
##           master   #4930      +/-   ##
=========================================
- Coverage    84.6%   68.4%   -16.2%     
=========================================
  Files        1205     509     -696     
  Lines       50141   26032   -24109     
  Branches     1074     195     -879     
=========================================
- Hits        42453   17824   -24629     
- Misses       7462    8159     +697     
+ Partials      226      49     -177

Flag	Coverage Δ
integrationtests	`65.2% <100.0%> (?)`
unittests	`84.1% <100.0%> (-0.6%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...ore_service_director_v2/modules/clusters_keeper.py	`45.4% <100.0%> (+2.5%)`	⬆️
...rector_v2/modules/comp_scheduler/dask_scheduler.py	`92.1% <ø> (+3.9%)`	⬆️

... and 1003 files with indirect coverage changes

matusdrobuliak66 approved these changes

View reviewed changes

pcrespov approved these changes

View reviewed changes


          pass the wallet ID

2d6e0fb

sanderegg force-pushed the comp-backend/connect-walletid-to-clusters-keeper branch from 5f89d36 to 2d6e0fb Compare

October 26, 2023 12:16

codeclimate bot commented Oct 26, 2023

Code Climate has analyzed commit 2d6e0fb and detected 0 issues on this pull request.

View more on Code Climate.

sonarqubecloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

sanderegg merged commit 4d27da3 into ITISFoundation:master

sanderegg deleted the comp-backend/connect-walletid-to-clusters-keeper branch

October 26, 2023 12:30

This was referenced Oct 26, 2023

🚀 Pre-release master -> staging_Microhistory4 #4934

Closed

🚀 Release v1.62.0 #4957

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

matusdrobuliak66 matusdrobuliak66 approved these changes

pcrespov pcrespov approved these changes

mrnicegyu11 mrnicegyu11 approved these changes

GitHK Awaiting requested review from GitHK GitHK is a code owner

mguidon Awaiting requested review from mguidon

Labels