✨ Sending message to iframe for theme switching #4951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignapas
requested review from
jsaq007,
GitHK,
elisabettai,
pcrespov,
odeimaiz,
mguidon and
sanderegg
pcrespov
reviewed
Oct 30, 2023
odeimaiz
approved these changes
Oct 30, 2023
pcrespov
approved these changes
Oct 30, 2023
sanderegg
approved these changes
Oct 30, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
Code Climate has analyzed commit 5a2a7a1 and detected 0 issues on this pull request. View more on Code Climate. |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Use
postMessageto send a formatted message to theiframewhenever the theme is switched and after it is loaded.The message has the following format:
osparc;theme=<theme_name>Related issue/s
How to test
Manually by changing the theme and seeing it arriving to the iframed UI. S4L should react to this after the latest version is deployed (3.1.10 or 3.1.11)
DevOps Checklist