Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 when updating comp_task table always give actual wallet info #4955

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Oct 31, 2023

What do these changes do?

  • 🐛 when updating comp_task table always give actual wallet info
    (Before the wallet info was provided only when we started a service, but when we updated service, for example by moving it in the UI, we have overwritten the wallet info to NULL)

Related issue/s

How to test

DevOps Checklist

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Oct 31, 2023

Code Climate has analyzed commit 9a08216 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #4955 (9a08216) into master (809a4d6) will decrease coverage by 3.4%.
The diff coverage is 60.6%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4955     +/-   ##
========================================
- Coverage    84.8%   81.5%   -3.4%     
========================================
  Files         636     514    -122     
  Lines       30912   26171   -4741     
  Branches      551     195    -356     
========================================
- Hits        26236   21332   -4904     
- Misses       4549    4790    +241     
+ Partials      127      49     -78     
Flag Coverage Δ
integrationtests 65.2% <60.6%> (+0.1%) ⬆️
unittests 86.4% <60.6%> (+0.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...simcore_service_webserver/director_v2/_handlers.py 92.5% <100.0%> (+7.6%) ⬆️
...ervice_webserver/director_v2/_core_computations.py 94.1% <66.6%> (+<0.1%) ⬆️
...imcore_service_webserver/director_v2/_api_utils.py 57.1% <57.1%> (ø)

... and 183 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review October 31, 2023 08:09
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@matusdrobuliak66 matusdrobuliak66 self-assigned this Oct 31, 2023
@matusdrobuliak66 matusdrobuliak66 added this to the Microhistory milestone Oct 31, 2023
@matusdrobuliak66 matusdrobuliak66 merged commit e04a211 into ITISFoundation:master Oct 31, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 23, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants