Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Adding new cli option to debug internal status of director-v2 #4963

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Oct 31, 2023

What do these changes do?

This allows to peak into the memory of director-v2 to see what it's actually tracking. There is an issue on production which is not allowing us to debug what is happening. This will help.

Related issue/s

How to test

DevOps Checklist

@GitHK GitHK marked this pull request as ready for review October 31, 2023 15:33
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #4963 (b5ce092) into master (b0a50aa) will decrease coverage by 43.3%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4963      +/-   ##
=========================================
- Coverage    84.6%   41.3%   -43.3%     
=========================================
  Files        1214     312     -902     
  Lines       50347   15041   -35306     
  Branches     1076       0    -1076     
=========================================
- Hits        42606    6223   -36383     
- Misses       7514    8818    +1304     
+ Partials      227       0     -227     
Flag Coverage Δ
integrationtests 41.3% <ø> (?)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1140 files with indirect coverage changes

Copy link

codeclimate bot commented Oct 31, 2023

Code Climate has analyzed commit b5ce092 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GitHK please add labels, assignment, milestone to this PR. thx (I took the liberty to assign it to you)

@GitHK GitHK added this to the Microhistory milestone Nov 1, 2023
@GitHK GitHK added a:director-v2 issue related with the director-v2 service changelog:🎨enhancement labels Nov 1, 2023
@GitHK GitHK merged commit b37b6ed into ITISFoundation:master Nov 1, 2023
53 checks passed
@GitHK GitHK deleted the pr-osparc-add-cli-to-debug-state branch November 1, 2023 06:24
jsaq007 pushed a commit to jsaq007/osparc-simcore that referenced this pull request Nov 1, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 2, 2023
30 tasks
GitHK pushed a commit that referenced this pull request Nov 2, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 23, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants