Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ E2E: adds milliseconds to screenshot prefix + wait before checking the logs #4966

Merged
merged 1 commit into from
Nov 1, 2023
Merged

♻️ E2E: adds milliseconds to screenshot prefix + wait before checking the logs #4966

merged 1 commit into from
Nov 1, 2023

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Nov 1, 2023 •
edited
Loading

What do these changes do?

  • e2e screenshots now adds the milliseconds in the prefix name, this prevents having badly sorted screenshot files
  • wait 2 seconds between typing in the log filter and checking for the results.

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg added the e2e Bugs found by or related to the end-2-end testing label Nov 1, 2023
@sanderegg sanderegg added this to the Microhistory milestone Nov 1, 2023
@sanderegg sanderegg self-assigned this Nov 1, 2023
elisabettai
elisabettai approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, very helpful!

bisgaard-itis
bisgaard-itis approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the effort.

@sanderegg sanderegg force-pushed the maintenance/improve_e2e_log_finding branch from 84bbfc3 to 25bb7d6 Compare November 1, 2023 11:22
@sanderegg sanderegg enabled auto-merge (squash) November 1, 2023 11:22
@codeclimate CodeClimate
Copy link

codeclimate bot commented Nov 1, 2023

Code Climate has analyzed commit 25bb7d6 and detected 0 issues on this pull request.

View more on Code Climate.

@sanderegg sanderegg force-pushed the maintenance/improve_e2e_log_finding branch from 25bb7d6 to c11673e Compare November 1, 2023 15:05
@sanderegg sanderegg disabled auto-merge November 1, 2023 15:06
@sanderegg sanderegg merged commit 1f15a0f into ITISFoundation:master Nov 1, 2023
@sanderegg sanderegg deleted the maintenance/improve_e2e_log_finding branch November 1, 2023 15:06
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@GitHK GitHK mentioned this pull request Nov 7, 2023
Closed
15 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 23, 2023
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bisgaard-itis bisgaard-itis bisgaard-itis approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@pcrespov pcrespov pcrespov approved these changes

@elisabettai elisabettai elisabettai approved these changes

@GitHK GitHK GitHK approved these changes

@ignapas ignapas Awaiting requested review from ignapas

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

@SCA-ZMT SCA-ZMT Awaiting requested review from SCA-ZMT

Assignees

@sanderegg sanderegg

Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Milestone
Microhistory
Development

Successfully merging this pull request may close these issues.
6 participants
@sanderegg @GitHK @elisabettai @pcrespov @odeimaiz @bisgaard-itis