Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨adding dynamic-scheduler service (⚠️ devops) #4973

Merged
merged 28 commits into from
Nov 6, 2023

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Nov 2, 2023

What do these changes do?

  • The dynamic-scheduler will gradually be populated with the internals of the dynamic scheduler from director-v2. Code will gradually move into this service.
  • New functionality related to dynamic services will end un inside this service.
  • This will put the scalability of the dynamic backend in reach.

⚠️ devops

New service needs to be deployed with the stack

Captured env vars

LOG_FORMAT_LOCAL_DEV_ENABLED=${LOG_FORMAT_LOCAL_DEV_ENABLED}
RABBIT_HOST=${RABBIT_HOST}
RABBIT_PASSWORD=${RABBIT_PASSWORD}
RABBIT_PORT=${RABBIT_PORT}
RABBIT_SECURE=${RABBIT_SECURE}
RABBIT_USER=${RABBIT_USER}
REDIS_HOST=${REDIS_HOST}
REDIS_PORT=${REDIS_PORT}
DIRECTOR_V2_HOST=${DIRECTOR_V2_HOST}

Related issue/s

How to test

DevOps Checklist

@GitHK GitHK self-assigned this Nov 2, 2023
@GitHK GitHK added this to the Microhistory milestone Nov 2, 2023
@GitHK GitHK changed the title ✨new service dynamic-scheduler joins the bunch ✨new service dynamic-scheduler joins the bunch (⚠️ devops) Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #4973 (1a9fb30) into master (eddf172) will decrease coverage by 0.6%.
The diff coverage is 70.9%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4973     +/-   ##
========================================
- Coverage    86.9%   86.4%   -0.6%     
========================================
  Files        1220    1135     -85     
  Lines       50627   48152   -2475     
  Branches     1078     947    -131     
========================================
- Hits        44044   41624   -2420     
+ Misses       6346    6318     -28     
+ Partials      237     210     -27     
Flag Coverage Δ
integrationtests 63.7% <80.0%> (-1.4%) ⬇️
unittests 84.1% <70.9%> (-0.6%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ary/src/models_library/api_schemas__common/meta.py 100.0% <100.0%> (ø)
..._library/api_schemas_dynamic_scheduler/__init__.py 100.0% <100.0%> (ø)
.../src/simcore_service_api_server/api/routes/meta.py 100.0% <ø> (ø)
.../simcore_service_api_server/models/schemas/meta.py 100.0% <100.0%> (ø)
...ler/src/simcore_service_dynamic_scheduler/_meta.py 100.0% <100.0%> (ø)
...ervice_dynamic_scheduler/api/rest/_dependencies.py 100.0% <100.0%> (ø)
...core_service_dynamic_scheduler/api/rest/_health.py 100.0% <100.0%> (ø)
...imcore_service_dynamic_scheduler/api/rest/_meta.py 100.0% <100.0%> (ø)
...mcore_service_dynamic_scheduler/api/rest/routes.py 100.0% <100.0%> (ø)
...duler/src/simcore_service_dynamic_scheduler/cli.py 100.0% <100.0%> (ø)
... and 14 more

... and 114 files with indirect coverage changes

@GitHK GitHK changed the title ✨new service dynamic-scheduler joins the bunch (⚠️ devops) ✨adding dynamic-scheduler service (⚠️ devops) Nov 3, 2023
@GitHK GitHK marked this pull request as ready for review November 3, 2023 08:07
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the dynamic scheduler!

One thing i started doing with new services is to get a starting coverage of >99%. this is very helpful to keep caring for this number being as high as possible.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@GitHK GitHK requested a review from bisgaard-itis as a code owner November 3, 2023 11:27
@GitHK GitHK enabled auto-merge (squash) November 6, 2023 06:44
Copy link

codeclimate bot commented Nov 6, 2023

Code Climate has analyzed commit 1a9fb30 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarqubecloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@GitHK GitHK merged commit 1f92ca7 into ITISFoundation:master Nov 6, 2023
53 checks passed
@GitHK GitHK deleted the pr-osparc-add-new-service branch November 6, 2023 07:29
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 23, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants