-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨adding dynamic-scheduler
service (⚠️ devops)
#4973
Conversation
dynamic-scheduler
joins the bunchdynamic-scheduler
joins the bunch (⚠️ devops)
Codecov Report
@@ Coverage Diff @@
## master #4973 +/- ##
========================================
- Coverage 86.9% 86.4% -0.6%
========================================
Files 1220 1135 -85
Lines 50627 48152 -2475
Branches 1078 947 -131
========================================
- Hits 44044 41624 -2420
+ Misses 6346 6318 -28
+ Partials 237 210 -27
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dynamic-scheduler
joins the bunch (⚠️ devops)dynamic-scheduler
service (⚠️ devops)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to the dynamic scheduler!
One thing i started doing with new services is to get a starting coverage of >99%. this is very helpful to keep caring for this number being as high as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/_meta.py
Show resolved
Hide resolved
services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/models/schemas/meta.py
Outdated
Show resolved
Hide resolved
services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/utils/http_client.py
Show resolved
Hide resolved
Code Climate has analyzed commit 1a9fb30 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
dynamic-scheduler
will gradually be populated with the internals of the dynamic scheduler from director-v2. Code will gradually move into this service.New service needs to be deployed with the stack
dynamic-scheduler
osparc-ops-environments#417Captured env vars
Related issue/s
How to test
DevOps Checklist